My Site: fix iPad default selected row

[leandroalonso]

Part of #17873
Fixes #17958

This PR fixes a bug that has been there for quite some time: the default selected row when using iPad.

To test

With My Site Dashboard flag disabled:

1. Do a clean install of the app on an iPad
2. Login with an account with multiple sites
3. Accept the help when prompted
4. ✅ "Stats" should be the selected row
5. Tap any other section
6. Switch to another site
7. ✅ "Stats" should be the selected row

With My Site Dashboard flag enabled

1. Enable My Site Dashboard feature flag
2. Close and reopen the app
3. ✅ "Stats" should be the selected row
4. Tap "Home"
5. Switch to another site
6. ✅ "Stats" should be the selected row

Make sure to check the site that has Quick Start enabled too, "Stats" should be the selected row there.

My Site Dashboard flag enabled and dashboard as the default

1. Create a new site (this will make the Dashboard the default)
2. ✅ "Home" should be the selected row
3. Switch to another site
4. ✅ "Home" should be the selected row

Regression Notes

1. Potential unintended areas of impact
   iPhone

2. What I did to test those areas of impact (or what existing automated tests I relied on)
   Manually tested on iPhone

3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

• I have completed the Regression Notes.
• I have considered adding unit tests for my changes.
• I have considered adding accessibility improvements for my changes.
• I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

[wpmobilebot]

You can test the Jetpack changes on this Pull Request by downloading it from AppCenter here with build number: pr18118-f1af20c. IPA is available here. If you need access to this, you can ask a maintainer to add you.

[wpmobilebot]

You can test the WordPress changes on this Pull Request by downloading it from AppCenter here with build number: pr18118-f1af20c. IPA is available here. If you need access to this, you can ask a maintainer to add you.

[pachlava]

From my side, it all looks good! Tested on iPad simulator, and also checked for regressions on iPhone. Thanks, @leandroalonso!

[hassaanelgarem]

Works as described except for one issue.

After switching from a site that has Quick Start enabled to a site that doesn't have it enabled. The shown section is "Stats" but the selected cell is "Posts"

[momo-ozawa]

I'm seeing a something similar to what @hassaanelgarem mentioned above -- when switching from a site that has Quick Start enabled to a P2 site, "Stats" is shown but "Menus" is selected

[leandroalonso]

@momo-ozawa @hassaanelgarem the issues you were seeing should be fixed with the last commits. Could you please try again?

[hassaanelgarem]

Yes, the issue is fixed for me 🚀

[momo-ozawa]

LGTM!