Notification Comment details: add tracks for actions #18070
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #17790
Depends on: #18064
This adds event tracking specific to notification comments, replicated from
NotificationDetailsViewController
.To test:
Perform the following actions. Verify the events logged.
Notification Comments:
🔵 Tracked: notifications_comment_liked <blog_id: xxx, site_type: blog>
🔵 Tracked: notifications_comment_unliked <blog_id: xxx, site_type: blog>
🔵 Tracked: notifications_comment_unapproved <blog_id: xxx, site_type: blog>
🔵 Tracked: notifications_approved <blog_id: xxx, site_type: blog>
🔵 Tracked: notifications_flagged_as_spam <blog_id: xxx, site_type: blog>
🔵 Tracked: notifications_comment_trashed <blog_id: xxx, site_type: blog>
🔵 Tracked: notifications_replied_to <>
My Site Comments:
🔵 Tracked: comment_liked <blog_id: xxx, comment_id: yyy, context: sites, post_id: zzz, site_type: blog>
🔵 Tracked: comment_unliked <blog_id: xxx, comment_id: yyy, context: sites, post_id: zzz, site_type: blog>
🔵 Tracked: comment_unapproved <blog_id: xxx, comment_id: yyy, context: sites, post_id: zzz, site_type: blog>
🔵 Tracked: comment_approved <blog_id: xxx, comment_id: yyy, context: sites, post_id: zzz, site_type: blog>
🔵 Tracked: comment_spammed <blog_id: xxx, comment_id: yyy, context: sites, post_id: zzz, site_type: blog>
🔵 Tracked: comment_trashed <blog_id: xxx, comment_id: yyy, context: sites, post_id: zzz, site_type: blog>
🔵 Tracked: comment_replied_to <blog_id: xxx, comment_id: yyy, context: sites, post_id: zzz, site_type: blog>
Regression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
PR submission checklist:
RELEASE-NOTES.txt
if necessary.