Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification Comment details: add tracks for actions #18070

Merged
merged 1 commit into from
Mar 3, 2022

Conversation

ScoutHarris
Copy link
Contributor

@ScoutHarris ScoutHarris commented Mar 2, 2022

Ref: #17790
Depends on: #18064

This adds event tracking specific to notification comments, replicated from NotificationDetailsViewController.

To test:
Perform the following actions. Verify the events logged.

Notification Comments:

  • Like - 🔵 Tracked: notifications_comment_liked <blog_id: xxx, site_type: blog>
  • Unlike - 🔵 Tracked: notifications_comment_unliked <blog_id: xxx, site_type: blog>
  • Pending - 🔵 Tracked: notifications_comment_unapproved <blog_id: xxx, site_type: blog>
  • Approve - 🔵 Tracked: notifications_approved <blog_id: xxx, site_type: blog>
  • Spam - 🔵 Tracked: notifications_flagged_as_spam <blog_id: xxx, site_type: blog>
  • Trash - 🔵 Tracked: notifications_comment_trashed <blog_id: xxx, site_type: blog>
  • Reply - 🔵 Tracked: notifications_replied_to <>

My Site Comments:

  • Like - 🔵 Tracked: comment_liked <blog_id: xxx, comment_id: yyy, context: sites, post_id: zzz, site_type: blog>
  • Unlike - 🔵 Tracked: comment_unliked <blog_id: xxx, comment_id: yyy, context: sites, post_id: zzz, site_type: blog>
  • Pending - 🔵 Tracked: comment_unapproved <blog_id: xxx, comment_id: yyy, context: sites, post_id: zzz, site_type: blog>
  • Approve - 🔵 Tracked: comment_approved <blog_id: xxx, comment_id: yyy, context: sites, post_id: zzz, site_type: blog>
  • Spam - 🔵 Tracked: comment_spammed <blog_id: xxx, comment_id: yyy, context: sites, post_id: zzz, site_type: blog>
  • Trash - 🔵 Tracked: comment_trashed <blog_id: xxx, comment_id: yyy, context: sites, post_id: zzz, site_type: blog>
  • Reply - 🔵 Tracked: comment_replied_to <blog_id: xxx, comment_id: yyy, context: sites, post_id: zzz, site_type: blog>

Regression Notes

  1. Potential unintended areas of impact

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@wpmobilebot
Copy link
Contributor

You can test the Jetpack changes on this Pull Request by downloading it from AppCenter here with build number: pr18070-6642363. IPA is available here. If you need access to this, you can ask a maintainer to add you.

@wpmobilebot
Copy link
Contributor

You can test the WordPress changes on this Pull Request by downloading it from AppCenter here with build number: pr18070-6642363. IPA is available here. If you need access to this, you can ask a maintainer to add you.

Copy link
Contributor

@dvdchr dvdchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

Base automatically changed from feature/17790-mind_the_gap to trunk March 3, 2022 19:25
@ScoutHarris ScoutHarris merged commit 7ff3f64 into trunk Mar 3, 2022
@ScoutHarris ScoutHarris deleted the feature/17790-tracks branch March 3, 2022 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants