Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification Comment details: enable feature for release #18071

Closed
wants to merge 2 commits into from

Conversation

ScoutHarris
Copy link
Contributor

@ScoutHarris ScoutHarris commented Mar 2, 2022

Ref: #17790

This enables the new Comment details view for Comment Notifications.

To test:

TLDR - verify everything works as expected.

  • Go to Notifications > comment notification.
  • Verify the new details view is displayed.
  • Verify Spam, Trash, and deleted comments are removed from the notifications list.
  • Verify the ⬆️ and ⬇️ nav bar buttons display the previous and next notification.
  • Verify Edit, Reply, and Like work as expected.

comment_details

Regression Notes

  1. Potential unintended areas of impact
    Should be none.

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    Tested Notification Comments and My Site Comments to be sure both work as expected.

  3. What automated tests I added (or what prevented me from doing so)
    N/A

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Mar 2, 2022

You can test the Jetpack changes on this Pull Request by downloading it from AppCenter here with build number: pr18071-3b56b48. IPA is available here. If you need access to this, you can ask a maintainer to add you.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Mar 2, 2022

You can test the WordPress changes on this Pull Request by downloading it from AppCenter here with build number: pr18071-3b56b48. IPA is available here. If you need access to this, you can ask a maintainer to add you.

@ScoutHarris ScoutHarris requested a review from dvdchr March 2, 2022 22:49
@ScoutHarris ScoutHarris marked this pull request as ready for review March 2, 2022 22:49
Copy link
Contributor

@dvdchr dvdchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit:

Base automatically changed from feature/17790-tracks to trunk March 3, 2022 19:25
@ScoutHarris ScoutHarris modified the milestones: 19.4, 19.5 Mar 4, 2022
@ScoutHarris ScoutHarris marked this pull request as draft March 8, 2022 22:36
@ScoutHarris ScoutHarris removed this from the 19.5 milestone Mar 8, 2022
@ScoutHarris ScoutHarris closed this Mar 8, 2022
@ScoutHarris ScoutHarris deleted the feature/17790-enable_feature branch March 8, 2022 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants