Jetpack: add SIWA to 18.9 #17693
Merged
Jetpack: add SIWA to 18.9 #17693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can trigger an installable build for these changes by visiting CircleCI here. |
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
mokagio
approved these changes
Dec 21, 2021
|
@leandroalonso this has been bundled as part of 18.9 beta 2 (18.9.0.2). Thanks for your work 🙌
The 18.9.0.2 build is now available. I tested signing in with email forwarding and it "worked", meaning it showed me the "no sites" screen, as expected. I don't have a SIWA account setup, so I haven't been able to test that particular flow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SIWA was added to 18.8 on #17671 and #17675. This PR simply cherry-picks the commits to
18.9.To test