Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jetpack: add Sign In With Apple #17671

Merged
merged 2 commits into from
Dec 13, 2021
Merged

Conversation

leandroalonso
Copy link
Contributor

This PR adds the SIWA button/flow on the Jetpack app.

Keep in mind that in order to fully test this flow it will need:

  1. To download this app version from TestFlight
  2. To submit and deploy some small changes on the backend

To test

  1. Make sure the CI is all green

@jkmassel let me know if you have a better idea on how to test this PR.

Regression Notes

  1. Potential unintended areas of impact
    n/a

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    n/a

  3. What automated tests I added (or what prevented me from doing so)
    n/a

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

You can trigger an installable build for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@jkmassel jkmassel merged commit d593fa0 into release/18.8 Dec 13, 2021
@jkmassel jkmassel deleted the task/jetpack_apple_sign_in branch December 13, 2021 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants