Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter media types when presenting the Media Picker for Mobile Gutenberg #17670

Merged
merged 4 commits into from
Jan 18, 2022

Conversation

twstokes
Copy link
Contributor

@twstokes twstokes commented Dec 11, 2021

Fixes:

To test:

Images

  1. Ensure at least one image and one video exist in the Photos app and that the WordPress app has appropriate access (configure access to Photos in iOS Settings -> WordPress). It's simplest to allow access to All Photos.
  2. Start a new Post and add an Image block
  3. Tap "Add Image".
  4. Tap "Choose from device".
  5. Thumbnails of videos should not be shown
  6. Videos should so a count of 0

Videos

  1. Ensure at least one image and one video exist in the Photos app and that the WordPress app has appropriate access (configure access to Photos in iOS Settings -> WordPress). It's simplest to allow access to All Photos.
  2. Start a new Post and add an Video block
  3. Tap "Add Video".
  4. Tap "Choose from device".
  5. Thumbnails of images should not be shown

Screenshots

Before

Before After
RPReplay_Final1639256947.MP4
RPReplay_Final1639257162.MP4

Regression Notes

  1. Potential unintended areas of impact
    Any blocks that allow uploading media from the device such as the Image, Gallery, Video, and Media & Text blocks.

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    I manually tested this on a device.

  3. What automated tests I added (or what prevented me from doing so)
    None.

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Dec 11, 2021

You can trigger an installable build for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Dec 11, 2021

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@twstokes twstokes added this to the 19.1 milestone Jan 13, 2022
@twstokes twstokes marked this pull request as ready for review January 13, 2022 19:29
@twstokes twstokes requested a review from ttahmouch January 18, 2022 18:38
Copy link
Contributor

@ttahmouch ttahmouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel weird approving the changes because I'm not super familiar with the code, but if you'd like to also seek a second opinion I totally understand.

@twstokes
Copy link
Contributor Author

I feel weird approving the changes because I'm not super familiar with the code, but if you'd like to also seek a second opinion I totally understand.

No worries! Thanks for taking the time and providing your feedback. I can also get a glance from an iOS dev.

Copy link
Contributor

@frosty frosty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, and fixes the issue!

@twstokes twstokes enabled auto-merge January 18, 2022 21:01
@twstokes twstokes merged commit f135e14 into trunk Jan 18, 2022
@twstokes twstokes deleted the fix/gm4371 branch January 18, 2022 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants