-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filter media types when presenting the Media Picker for Mobile Gutenberg #17670
Conversation
You can trigger an installable build for these changes by visiting CircleCI here. |
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
WordPress/Classes/ViewRelated/Gutenberg/GutenbergMediaPickerHelper.swift
Outdated
Show resolved
Hide resolved
WordPress/Classes/ViewRelated/Gutenberg/GutenbergMediaPickerHelper.swift
Show resolved
Hide resolved
WordPress/Classes/ViewRelated/Gutenberg/GutenbergMediaPickerHelper.swift
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel weird approving the changes because I'm not super familiar with the code, but if you'd like to also seek a second opinion I totally understand.
No worries! Thanks for taking the time and providing your feedback. I can also get a glance from an iOS dev. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, and fixes the issue!
Fixes:
To test:
Images
Videos
Screenshots
Before
RPReplay_Final1639256947.MP4
RPReplay_Final1639257162.MP4
Regression Notes
Potential unintended areas of impact
Any blocks that allow uploading media from the device such as the Image, Gallery, Video, and Media & Text blocks.
What I did to test those areas of impact (or what existing automated tests I relied on)
I manually tested this on a device.
What automated tests I added (or what prevented me from doing so)
None.
PR submission checklist:
RELEASE-NOTES.txt
if necessary.