Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS: Image and Video blocks don't filter their media types on Albums view #4371

Closed
twstokes opened this issue Dec 11, 2021 · 4 comments
Closed
Labels

Comments

@twstokes
Copy link
Contributor

Describe the bug

  • When selecting "Choose from device" on an Image block, videos are still visible and counted on the Albums view
  • When selecting "Choose from device" on an Video block, images are still visible and counted on the Albums view

To Reproduce

Steps to reproduce the behavior for images:

  1. Ensure at least one image and one video exist in the Photos app and that the WordPress app has appropriate access (configure access to Photos in iOS Settings -> WordPress). It's simplest to allow access to All Photos.
  2. Start a new Post and add an Image block
  3. Tap "Add Image".
  4. Tap "Choose from device".
  5. Observe that thumbnails of videos are shown as well as the count.
  6. Observe that when tapping on "Videos" the message "You don't have any media." is shown.

Steps to reproduce the behavior for videos:

  1. Ensure at least one image and one video exist in the Photos app and that the WordPress app has appropriate access (configure access to Photos in iOS Settings -> WordPress). It's simplest to allow access to All Photos.
  2. Start a new Post and add an Video block
  3. Tap "Add Video".
  4. Tap "Choose from device".
  5. Observe that thumbnails of images are shown as well as the count.
  6. Observe that when tapping on "Recents" only videos are shown.

Expected behavior

  • When adding images from the device, video thumbnails nor counts are shown
  • When adding videos from the device, image thumbnails nor counts are shown

Screenshots

RPReplay_Final1639256947.MP4

Smartphone

  • Device: iPhone 12
  • OS: iOS 15.1.1
  • Version: WordPress iOS 18.8 / 1.67.0 Mobile Gutenberg
@twstokes
Copy link
Contributor Author

@hypest
Copy link
Contributor

hypest commented Dec 13, 2021

Thanks for the report and the fix PR @twstokes! Is this a regression?

@twstokes
Copy link
Contributor Author

Thanks for the report and the fix PR @twstokes! Is this a regression?

I don't believe so @hypest, I'd noticed it during testing.

@hypest
Copy link
Contributor

hypest commented Apr 15, 2022

Fixed by wordpress-mobile/WordPress-iOS#17670

@hypest hypest closed this as completed Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants