Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post Details Comments: add table header with comments count #17560

Merged
merged 7 commits into from
Nov 26, 2021

Conversation

ScoutHarris
Copy link
Contributor

@ScoutHarris ScoutHarris commented Nov 24, 2021

Ref: #17511

This adds a custom table header view for the Comments table that displays the total comment count.

I also made a couple changes to the BorderedButtonTableViewCell:

  • Fixed an issue where overriding the button insets didn't actually work. 🤦
  • Set the default button insets to 0.

⚠️ Auto-merge enabled ⚠️

To test:

  • Enable the postDetailsComments feature.
  • Go to Reader > post with comments > details.
  • Verify the XX Comments header is displayed with the total number of comments.

comments_header

Regression Notes

  1. Potential unintended areas of impact
    N/A. WIP.

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    N/A. WIP.

  3. What automated tests I added (or what prevented me from doing so)
    N/A. WIP.

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Nov 24, 2021

You can trigger an installable build for these changes by visiting CircleCI here.

@ScoutHarris ScoutHarris requested a review from dvdchr November 24, 2021 23:22
@ScoutHarris ScoutHarris marked this pull request as ready for review November 24, 2021 23:22
@ScoutHarris
Copy link
Contributor Author

Hey @dvdchr .

If changes are needed that prevent approval, would you mind removing the 18.8 Milestone? Thank you!!

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Nov 24, 2021

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

Copy link
Contributor

@dvdchr dvdchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a few visual issues, and nothing major. Approving since this is still WIP! 👍

Simulator Screen Shot - iPhone 12 - 2021-11-26 at 16 42 41

  • Somehow the header view is displayed with a gray background for me, but it is displayed correctly in your screenshot 🤔 .
  • I just realized while checking the designs in Zeplin earlier, but I think the "View All Comments" button should have a lighter gray border instead of having the .text color... (maybe it should be separator?). Here's the design from Zeplin:
    Screen Shot 2021-11-26 at 17 01 48

@ScoutHarris ScoutHarris merged commit cec4dcd into develop Nov 26, 2021
@ScoutHarris ScoutHarris deleted the feature/17511-comments_table_header branch November 26, 2021 10:02
@ScoutHarris
Copy link
Contributor Author

Hey @dvdchr .

the header view is displayed with a gray background for me

Huh, that's not good. I'll take a look! Thanks!

button should have a lighter gray border

Yea, I noted that when I added the button: The design has the button border and label different colors. I'll add this functionality in a follow-up PR.

I just haven't done it yet.

@dvdchr
Copy link
Contributor

dvdchr commented Nov 30, 2021

Yea, I noted that when I added the button:

Oh, got it! 👍 Sorry, that must've escaped me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants