Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post Details Comments: add view all comments button to comments table #17548

Merged
merged 4 commits into from
Nov 24, 2021

Conversation

ScoutHarris
Copy link
Contributor

@ScoutHarris ScoutHarris commented Nov 24, 2021

Ref: #17511
Depends on: #17546

This displays a View All Comments button in the last row of the Comments table. Tapping it will display the threaded comments view.

Also, the comments table no longer shows separators or row selection.

Notes:

  • The design has the button border and label different colors. I'll add this functionality in a follow-up PR.
  • There are still empty rows above the button where the Comments will eventually be displayed.

To test:

  • Enable the postDetailsComments feature.
  • Go to Reader > post > details.
  • Verify the View All Comments button is displayed.
  • Verify tapping it displays the threaded comments view.

view_all

Regression Notes

  1. Potential unintended areas of impact
    N/A. WIP.

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    N/A. WIP.

  3. What automated tests I added (or what prevented me from doing so)
    N/A. WIP.

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Nov 24, 2021

You can trigger an installable build for these changes by visiting CircleCI here.

@ScoutHarris ScoutHarris requested a review from dvdchr November 24, 2021 02:15
@ScoutHarris ScoutHarris marked this pull request as ready for review November 24, 2021 02:15
@peril-wordpress-mobile
Copy link

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

Copy link
Contributor

@dvdchr dvdchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit:

Base automatically changed from feature/17511-fetch_comments to develop November 24, 2021 18:49
@peril-wordpress-mobile
Copy link

Warnings
⚠️ This PR is assigned to a milestone which is closing in less than 4 days Please, make sure to get it merged by then or assign it to a later expiring milestone

Generated by 🚫 dangerJS

@ScoutHarris ScoutHarris merged commit 71b3aab into develop Nov 24, 2021
@ScoutHarris ScoutHarris deleted the feature/17511-show_all_button branch November 24, 2021 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants