Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds tracking when expanding items on the Stats: Post Stats view #17552

Merged
merged 4 commits into from
Nov 24, 2021
Merged

Adds tracking when expanding items on the Stats: Post Stats view #17552

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
604e001
Add new WPAnalyticsStat items
Nov 24, 2021
cb76a14
Add tracking when the months / weeks items are expanded on the Stats …
Nov 24, 2021
33b43d9
Update Podfile.lock
Nov 24, 2021
377b596
Update WordPressShared to 1.17.0-beta.1
Nov 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Podfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,9 @@ workspace 'WordPress.xcworkspace'
## ===================================
##
def wordpress_shared
pod 'WordPressShared', '~> 1.16.2'
#pod 'WordPressShared', '~> 1.17.0'
#pod 'WordPressShared', :git => 'https://github.com/wordpress-mobile/WordPress-iOS-Shared.git', :tag => ''
#pod 'WordPressShared', :git => 'https://github.com/wordpress-mobile/WordPress-iOS-Shared.git', :branch => ''
pod 'WordPressShared', :git => 'https://github.com/wordpress-mobile/WordPress-iOS-Shared.git', :branch => 'issue/17503-add-stats-tracking'
#pod 'WordPressShared', :git => 'https://github.com/wordpress-mobile/WordPress-iOS-Shared.git', :commit => ''
#pod 'WordPressShared', :path => '../WordPress-iOS-Shared'
end
Expand Down
11 changes: 8 additions & 3 deletions Podfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -555,7 +555,7 @@ DEPENDENCIES:
- WordPressAuthenticator (~> 1.42.1)
- WordPressKit (~> 4.44.0-beta)
- WordPressMocks (~> 0.0.15)
- WordPressShared (~> 1.16.2)
- WordPressShared (from `https://github.com/wordpress-mobile/WordPress-iOS-Shared.git`, branch `issue/17503-add-stats-tracking`)
- WordPressUI (~> 1.12.2)
- WPMediaPicker (~> 1.7.2)
- Yoga (from `https://raw.githubusercontent.com/wordpress-mobile/gutenberg-mobile/v1.66.0/third-party-podspecs/Yoga.podspec.json`)
Expand Down Expand Up @@ -607,7 +607,6 @@ SPEC REPOS:
- WordPress-Aztec-iOS
- WordPress-Editor-iOS
- WordPressMocks
- WordPressShared
- WPMediaPicker
- wpxmlrpc
- ZendeskCommonUISDK
Expand Down Expand Up @@ -711,6 +710,9 @@ EXTERNAL SOURCES:
:git: https://github.com/wordpress-mobile/gutenberg-mobile.git
:submodules: true
:tag: v1.66.0
WordPressShared:
:branch: issue/17503-add-stats-tracking
:git: https://github.com/wordpress-mobile/WordPress-iOS-Shared.git
Yoga:
:podspec: https://raw.githubusercontent.com/wordpress-mobile/gutenberg-mobile/v1.66.0/third-party-podspecs/Yoga.podspec.json

Expand All @@ -726,6 +728,9 @@ CHECKOUT OPTIONS:
:git: https://github.com/wordpress-mobile/gutenberg-mobile.git
:submodules: true
:tag: v1.66.0
WordPressShared:
:commit: 78dbd61a3843a3402c611146d212de7402febdd4
:git: https://github.com/wordpress-mobile/WordPress-iOS-Shared.git

SPEC CHECKSUMS:
1PasswordExtension: f97cc80ae58053c331b2b6dc8843ba7103b33794
Expand Down Expand Up @@ -826,6 +831,6 @@ SPEC CHECKSUMS:
ZendeskSupportSDK: 3a8e508ab1d9dd22dc038df6c694466414e037ba
ZIPFoundation: e27423c004a5a1410c15933407747374e7c6cb6e

PODFILE CHECKSUM: 70e2c1b2bb057852c4af271041294e98678f6963
PODFILE CHECKSUM: 030156e7c5684c9820285184eb4737fc01094ed7

COCOAPODS: 1.10.1
6 changes: 6 additions & 0 deletions WordPress/Classes/Utility/Analytics/WPAnalyticsTrackerAutomatticTracks.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1748,6 +1748,12 @@ + (TracksEventPair *)eventPairForStat:(WPAnalyticsStat)stat
case WPAnalyticsStatStatsItemTappedInsightsAddStat:
eventName = @"stats_add_insight_item_tapped";
break;
case WPAnalyticsStatStatsItemTappedPostStatsMonthsYears:
eventName = @"stats_posts_and_pages_months_years_item_tapped";
break;
case WPAnalyticsStatStatsItemTappedPostStatsRecentWeeks:
eventName = @"stats_posts_and_pages_recent_weeks_item_tapped";
break;
case WPAnalyticsStatStatsItemTappedInsightsCustomizeDismiss:
eventName = @"stats_customize_insights_dismiss_item_tapped";
break;
Expand Down
4 changes: 4 additions & 0 deletions WordPress/Classes/ViewRelated/Stats/Shared Views/StatsTotalRow.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -460,6 +460,10 @@ private extension StatSection {
return .statsItemTappedVideoTapped
case .insightsAddInsight:
return .statsItemTappedInsightsAddStat
case .postStatsMonthsYears:
return .statsItemTappedPostStatsMonthsYears
case .postStatsRecentWeeks:
return .statsItemTappedPostStatsRecentWeeks
default:
return nil
}
Expand Down