Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds tracking when expanding items on the Stats: Post Stats view #17552

Merged
merged 4 commits into from
Nov 24, 2021

Conversation

emilylaguna
Copy link
Contributor

Project: #17503
Depends on WPiOS Shared PR: wordpress-mobile/WordPress-iOS-Shared#303

To test:

  1. Launch the app
  2. Tap on the My Site tab
  3. Tap on the 'Stats' item
  4. Tap on an item under 'Posts and Pages' to open the 'Post Stats' view
  5. Under Months and Years tap the down arrow to expand a section
  6. Verify you see: 🔵 Tracked: stats_posts_and_pages_months_years_item_tapped <blog_id: BLOG_ID, site_type: SITE_TYPE>
  7. Under Recent Weeks tap the down arrow to expand a section
  8. Verify you see: 🔵 Tracked: stats_posts_and_pages_recent_weeks_item_tapped <blog_id: BLOG_ID, site_type: SITE_TYPE>

Regression Notes

  1. Potential unintended areas of impact
    None

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    None

  3. What automated tests I added (or what prevented me from doing so)
    None

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Nov 24, 2021

You can trigger an installable build for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Nov 24, 2021

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

Copy link
Contributor

@momo-ozawa momo-ozawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as described!
Approved the corresponding WPiOS Shared PR 😄

@emilylaguna emilylaguna merged commit ef3827d into develop Nov 24, 2021
@emilylaguna emilylaguna deleted the issue/17503-add-stats-tracking branch November 24, 2021 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants