Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate tracks items #17514

Merged
merged 2 commits into from
Nov 22, 2021
Merged

Conversation

emilylaguna
Copy link
Contributor

Project: #17503

Description

Fixes a couple instances of tracks being duplicated when:

  • The People view is accessed
  • The Reader Saved list is accessed

To test:

People list

  1. Go to the My Site tab
  2. Scroll down to the People item
  3. Tap on the People item
  4. Verify you see only 1: 🔵 Tracked: people_management_list_opened <blog_id: BLOG_ID, site_type: blog>

Reader Saved Accessed

  1. Go to the Reader Tab
  2. Tap on the 'Saved' item
  3. Verify you see only 1: 🔵 Tracked: reader_saved_list_shown <source: reader_filter, subscription_count: COUNT>

Regression Notes

  1. Potential unintended areas of impact
    None, adding tracks to specific areas.

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    Manual testing

  3. What automated tests I added (or what prevented me from doing so)
    None.

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

You can trigger an installable build for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

Copy link
Contributor

@Gio2018 Gio2018 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

worked as described. :shipit: !

@emilylaguna emilylaguna merged commit dfa2dc1 into develop Nov 22, 2021
@emilylaguna emilylaguna deleted the issue/17503-remove-duplicate-tracks branch November 22, 2021 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants