Merge pull request #17514 from wordpress-mobile/issue/17503-remove-du…

…plicate-tracks Remove duplicate tracks items
wordpress-mobile · Nov 22, 2021 · dfa2dc1 · dfa2dc1
2 parents 1c27148 + 9316132
commit dfa2dc1
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/WordPress/Classes/ViewRelated/Blog/Blog Details/BlogDetailsViewController.m b/WordPress/Classes/ViewRelated/Blog/Blog Details/BlogDetailsViewController.m
@@ -1717,7 +1717,6 @@ - (void)showMediaLibraryFromSource:(BlogDetailsNavigationSource)source
 
 - (void)showPeople
 {
-    [WPAppAnalytics track:WPAnalyticsStatOpenedPeople withBlog:self.blog];
     PeopleViewController *controller = [PeopleViewController controllerWithBlog:self.blog];
     controller.navigationItem.largeTitleDisplayMode = UINavigationItemLargeTitleDisplayModeNever;
     [self showDetailViewController:controller sender:self];

diff --git a/WordPress/Classes/ViewRelated/People/PeopleViewController.swift b/WordPress/Classes/ViewRelated/People/PeopleViewController.swift
@@ -169,7 +169,12 @@ class PeopleViewController: UITableViewController, UIViewControllerRestoration {
         super.viewWillAppear(animated)
         tableView.deselectSelectedRowWithAnimation(true)
         refreshNoResultsView()
-        WPAnalytics.track(.openedPeople)
+
+        guard let blog = blog else {
+            return
+        }
+
+        WPAppAnalytics.track(.openedPeople, with: blog)
     }
 
     override func viewWillTransition(to size: CGSize, with coordinator: UIViewControllerTransitionCoordinator) {

diff --git a/WordPress/Classes/ViewRelated/Reader/ReaderStreamViewController.swift b/WordPress/Classes/ViewRelated/Reader/ReaderStreamViewController.swift
@@ -170,7 +170,7 @@ import WordPressFlux
 
     var contentType: ReaderContentType = .topic {
         didSet {
-            if contentType == .saved {
+            if oldValue != .saved, contentType == .saved {
                 updateContent(synchronize: false)
                 trackSavedListAccessed()
             }