Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gutenberg] Update dependencies from forks to use release tags #16724

Merged
merged 9 commits into from
Jul 20, 2021

Conversation

ceyhun
Copy link
Contributor

@ceyhun ceyhun commented Jun 22, 2021

Gutenberg PR: WordPress/gutenberg#32893
Gutenberg Mobile PR: wordpress-mobile/gutenberg-mobile#3651
WPiOS PR: #16724
WPAndroid PR: wordpress-mobile/WordPress-Android#14894

To test: See Gutenberg PR

Regression Notes

  1. Potential unintended areas of impact

Gutenberg Editor dark mode

  1. What I did to test those areas of impact (or what existing automated tests I relied on)

Manually tested the dark mode

  1. What automated tests I added (or what prevented me from doing so)

We don't yet have automated tests infrastructure around Gutenberg Editor in this repo to test this feature

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@ceyhun ceyhun added the Gutenberg Editing and display of Gutenberg blocks. label Jun 22, 2021
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Jun 22, 2021

You can trigger an installable build for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Jun 22, 2021

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@ceyhun ceyhun requested a review from dcalhoun July 13, 2021 13:21
@ceyhun ceyhun marked this pull request as ready for review July 13, 2021 13:21
@ceyhun ceyhun added this to the 17.9 milestone Jul 13, 2021
@ceyhun ceyhun requested review from fluiddot and removed request for dcalhoun July 15, 2021 15:41
Copy link
Contributor

@fluiddot fluiddot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via WordPress/gutenberg#32893 (review).

NOTE: The Gutenberg Mobile ref should be updated to a tag value before merging.

@ceyhun ceyhun enabled auto-merge July 20, 2021 11:51
@ceyhun ceyhun merged commit 517eb2f into develop Jul 20, 2021
@ceyhun ceyhun deleted the gutenberg/update-fork-refs branch July 20, 2021 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gutenberg Editing and display of Gutenberg blocks.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants