[RNMobile] Update dependencies from forks to use release tags #32893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ceyhun
added
the
Mobile App - i.e. Android or iOS
|
Size Change: 0 B Total Size: 1.07 MB ℹ️ View Unchanged
|
2 tasks
fluiddot
reviewed
Jul 19, 2021
There was a problem hiding this comment.
LGTM 🎊 .
I verified that the dark mode works as expected on iOS but I couldn't on Android because the installable build is not working (related comment), once I manage to verify the dark mode there I'll approve it.
fluiddot
approved these changes
Jul 19, 2021
There was a problem hiding this comment.
Related to this comment: #32893 (review)
I managed to test it on Android and works fine 🎊 so LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While upgrading to React Native 0.64 we used latest commit references for third party dependency forks' PRs and merged RN 0.64 upgrade PR before merging third party dependency forks' PRs and updating their references in RN 0.64 upgrade branch.
Firstly here, I merged the related third party dependency forks' PRs and created a branch called
wp-forkin all of them and moved fork-specific code (merged tomasterbranches before) there, reverting themasterbranches to only track the main repo's default branch.Then I opened a draft pull request in all of the fork repos to be able to track the diff between
wp-forkbranch and main repo's default branch.After that, I tagged the current
wp-forkbranches with the same version number, but with a-wpat the end (e.g.1.4.0-wp) and updated.podspecss, where necessary, to use forks' URL and-wptags (instead of commit hashes) as source.Finally I updated the dependencies in
package.jsonto use created tags on all forks.As an extra change, I removed
react-native-dark-modefork dependency, which didn't seem to be used.The RN 0.64 related third party dependency forks' PRs were:
Gutenberg PR: #32893
Gutenberg Mobile PR: wordpress-mobile/gutenberg-mobile#3651
WPiOS PR: wordpress-mobile/WordPress-iOS#16724
WPAndroid PR: wordpress-mobile/WordPress-Android#14894
How has this been tested?
Please use the WPiOS and WPAndroid builds to check if the editor and dark mode in the editor is still working.
Screenshots
N/A
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist:
*.native.jsfiles for terms that need renaming or removal).