Xpost Suggestions for Gutenberg #15139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Oct 20, 2020
WordPress/Classes/ViewRelated/Suggestions/SuggestionsTableView.swift
Outdated
Show resolved
Hide resolved
WordPress/Classes/ViewRelated/Suggestions/SuggestionsTableView.swift
Outdated
Show resolved
Hide resolved
WordPress/Classes/ViewRelated/Suggestions/SuggestionsTableView.swift
Outdated
Show resolved
Hide resolved
WordPress/Classes/ViewRelated/Suggestions/SuggestionsTableView.swift
Outdated
Show resolved
Hide resolved
guarani
changed the base branch from
develop
to
gutenberg/prepare-suggestions-for-xposts
guarani
added
Gutenberg compatibility
Gutenberg
guarani
changed the title
guarani
force-pushed
the
gutenberg/prepare-suggestions-for-xposts
branch
from
667db2f to
4329539
Compare
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
guarani
force-pushed
the
gutenberg/prepare-suggestions-for-xposts
branch
from
4329539 to
6966f0d
Compare
Base automatically changed from
gutenberg/prepare-suggestions-for-xposts
to
develop
October 21, 2020 18:08
guarani
force-pushed
the
gutenberg/implement-xpost-suggestions
branch
from
57802f6 to
7e6df8e
Compare
guarani
commented
Oct 21, 2020
WordPress/Classes/ViewRelated/Suggestions/SuggestionsTableView.h
Outdated
Show resolved
Hide resolved
guarani
force-pushed
the
gutenberg/implement-xpost-suggestions
branch
from
b5bfdee to
f1ba787
Compare
guarani
force-pushed
the
gutenberg/implement-xpost-suggestions
branch
from
720304f to
ef2f349
Compare
- Add xpost support to Gutenberg in `GutenbergViewController` - Extend `SuggestionsTableView` to support xposts - Extend `SuggestionService` to support xposts - Make filtering suggestions (both for xposts and @-mentions) case insensitive and diacritic insensitive) - Add a 60 second throttle to both xpost and @-mention network calls - Make `UserSuggestion` conform to `Decodable`
guarani
force-pushed
the
gutenberg/implement-xpost-suggestions
branch
from
ef2f349 to
a51eaef
Compare
2 tasks
guarani
changed the title
The use of the suggestions property getter to trigger the call to the API was prone to issues including multiple calls to the API being made instead of just one.
guarani
force-pushed
the
gutenberg/implement-xpost-suggestions
branch
2 times, most recently
from
00be286 to
0705d94
Compare
guarani
force-pushed
the
gutenberg/implement-xpost-suggestions
branch
from
0705d94 to
4ad27f6
Compare
antonis
reviewed
Dec 24, 2020
This was referenced Dec 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses wordpress-mobile/gutenberg-mobile#2602
Related PRs:
This PR adds to Gutenberg the ability to xpost to another site.
To test
What you'll need: A WordPress.com site that is capable of xposting to one or more other sites
Note: https://wordpress.com/p2/ can be used to create xpost-capable sites.
Xpost in Gutenberg
+and verify that the list of suggestions is shownPlease note: There are improvements coming to the Xpost feature before it will be shipped, this PR aims to bring Xposts the same level of functionality Mentions currently has, nothing more, nothing less. (Improvements include a request throttle, prefetching, analytics, etc.)
PR submission checklist
RELEASE-NOTES.txtif necessary.