Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add editor startup time #13605

Merged
merged 2 commits into from
Mar 17, 2020
Merged

Add editor startup time #13605

merged 2 commits into from
Mar 17, 2020

Conversation

koke
Copy link
Member

@koke koke commented Mar 9, 2020 •
edited
Loading

Adds startup time to the editor_session_start event.

Fixes wordpress-mobile/gutenberg-mobile#1988
Android PR: wordpress-mobile/WordPress-Android#11411

To test:

Look at the tracks logs in the console and ensure the startup_time_ms gets added to editor_session_start and it reflects the actual startup time of the editor.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@koke koke added Performance Analytics Gutenberg Editing and display of Gutenberg blocks. labels Mar 9, 2020
@koke koke added this to the 14.4 milestone Mar 9, 2020
@koke koke requested a review from SergioEstevao March 9, 2020 15:48
@peril-wordpress-mobile
Copy link

You can trigger an installable build for these changes by visiting CircleCI here.

@koke koke changed the title Add editor startup time to editor_session_start Add editor startup time Mar 9, 2020
@koke koke mentioned this pull request Mar 9, 2020
Merged
3 tasks
@loremattei loremattei modified the milestones: 14.4 ❄️, 14.5 Mar 9, 2020
@loremattei
Copy link
Contributor

Hey there! I'm moving this to 14.5 because 14.4 has just been cut. If you want this to make it to 14.4, please feel free to ping me!

SergioEstevao
SergioEstevao approved these changes Mar 17, 2020
View reviewed changes
Copy link
Contributor

@SergioEstevao SergioEstevao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@koke koke merged commit 1f225c7 into develop Mar 17, 2020
@koke koke deleted the add/editor_session_startup_time branch March 17, 2020 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergioEstevao SergioEstevao SergioEstevao approved these changes

Assignees
No one assigned
Labels
Analytics Gutenberg Editing and display of Gutenberg blocks. Performance
Projects
None yet
Milestone
14.5
Development

Successfully merging this pull request may close these issues.

Instrument editor startup performance
3 participants
@koke @loremattei @SergioEstevao