Add editor session startup time #11411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koke
force-pushed
the
add/editor_session_startup_time
branch
from
a92f1ce to
68c042b
Compare
|
Sorry for the force-push, I realized my |
3 tasks
|
You can test the changes on this Pull Request by downloading the APK here. |
maxme
reviewed
Mar 9, 2020
| @@ -2669,6 +2669,10 @@ private void onEditorFinalTouchesBeforeShowing() { | |||
|
|
|||
| @Override | |||
| public void onEditorFragmentContentReady(ArrayList<Object> unsupportedBlocksList) { | |||
| // Note that this method is also used to track startup performance | |||
maxme
reviewed
Mar 9, 2020
WordPress/src/main/java/org/wordpress/android/ui/posts/PostEditorAnalyticsSession.java
Show resolved
Hide resolved
|
We're freezing |
|
Thanks for taking care of that @koke - good job on your 2020 Android patch ;)
|
maxme
approved these changes
Mar 11, 2020
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds startup time to the
editor_session_startevent.Fixes wordpress-mobile/gutenberg-mobile#1988
iOS PR: wordpress-mobile/WordPress-iOS#13605
I do like one Android PR a year on average, so please let me know if there's a better way to do this 😅
To test:
Set a breakpoint or some extra logging on
AnalyticsTracker.track(), and ensure thestartup_time_msgets added toeditor_session_startand it reflects the actual startup time of the editor.PR submission checklist:
RELEASE-NOTES.txtif necessary.