Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Gutenberg for all builds #11045

Merged
merged 1 commit into from
Feb 15, 2019

Conversation

koke
Copy link
Member

@koke koke commented Feb 14, 2019

Fixes iOS part of wordpress-mobile/gutenberg-mobile#566

To test:

What I tried was editing the scheme to build the Release configuration. The Gutenberg setting in app settings wasn't available in develop but it is on this PR

@koke koke added the Gutenberg Editing and display of Gutenberg blocks. label Feb 14, 2019
@koke koke added this to the 11.9 milestone Feb 14, 2019
@koke koke requested a review from loremattei February 14, 2019 14:52
@loremattei
Copy link
Contributor

Yep! It's the time to do it :-)

The change works 👍.

I'm only wondering if we'd also update the title of switch (removing the part in the brackets) and maybe making it localisable. Wdyt @koke?

@koke
Copy link
Member Author

koke commented Feb 15, 2019

Already done in #11044 😁

Copy link
Contributor

@loremattei loremattei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You rock!!!
:shipit:

@koke koke merged commit a9448be into develop Feb 15, 2019
@koke koke deleted the issue/gutenberg-mobile-566-gutenberg-for-all-builds branch February 15, 2019 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gutenberg Editing and display of Gutenberg blocks.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants