Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update copy for Gutenberg toggle #11044

Merged
merged 1 commit into from
Feb 14, 2019

Conversation

koke
Copy link
Member

@koke koke commented Feb 14, 2019

👋🙉🙊😢

togglecopy

Fixes the iOS part of wordpress-mobile/gutenberg-mobile#567

To test:

  1. Go to App Settings
  2. Notice the lack of emoji and tension around the copy
  3. 😭

cc @hypest @iamthomasbishop

@koke koke added the Gutenberg Editing and display of Gutenberg blocks. label Feb 14, 2019
@koke koke added this to the 11.9 milestone Feb 14, 2019
@koke koke requested a review from etoledom February 14, 2019 14:36
Copy link
Contributor

@etoledom etoledom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most difficult PR to approve ever.
Forgive me.

@koke koke merged commit 88c9a01 into develop Feb 14, 2019
@koke koke deleted the issue/gutenberg-mobile-567-update-toggle-copy branch February 14, 2019 15:28
@iamthomasbishop
Copy link

I hate to be a buzzkill, but can we add a period at the end of the footer description to align with the HIG? 😬

@koke
Copy link
Member Author

koke commented Feb 15, 2019

Does 🙊 count as a period? 😂 Done in #11049

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gutenberg Editing and display of Gutenberg blocks.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants