Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Classic Block: Adding Images: App crashes when image permissions are not allowed #19965

Closed
joashrajin opened this issue Jan 23, 2023 · 8 comments · Fixed by #20666
Closed

Classic Block: Adding Images: App crashes when image permissions are not allowed #19965

joashrajin opened this issue Jan 23, 2023 · 8 comments · Fixed by #20666
Assignees
Milestone

Comments

@joashrajin
Copy link

Expected behavior

A warning should be given that image permissions need to be set

Actual behavior

The app crashes

Steps to reproduce the behavior

  • Ensure the JP/WP app has photo permissions set to None
  • Try to edit a page which has a classic block on it, press the '+' button to add an image
  • Notice the crash

Recording:

RPReplay_Final1674470652.MP4
Tested on [iPhone 14 Pro Max], iOS [16.2], WPiOS [21.4.1]
@salimbraksa salimbraksa self-assigned this Jan 23, 2023
@salimbraksa salimbraksa added this to the 21.7 milestone Jan 23, 2023
@mokagio
Copy link
Contributor

mokagio commented Feb 6, 2023

No PR has been linked to this issue, so I assume it hasn't been fixed yet or it hasn't been deemed urgent enough to address?

Anyways, I'll move the milestone to 21.8 because I'm about to start the 21.7 code freeze. Feel free to revert if necessary.

@mokagio mokagio modified the milestones: 21.7, 21.8 Feb 6, 2023
@mokagio
Copy link
Contributor

mokagio commented Feb 20, 2023

I'll move the milestone to 21.9 because I'm about to start the 21.8 code freeze. Feel free to revert if necessary.

@mokagio mokagio modified the milestones: 21.8, 21.9 Feb 20, 2023
@mokagio
Copy link
Contributor

mokagio commented Mar 6, 2023

I'll move the milestone to 22.0 because I'm about to start the 21.9 code freeze. Feel free to revert if necessary.

@mokagio mokagio modified the milestones: 21.9, 22.0 Mar 6, 2023
@mokagio
Copy link
Contributor

mokagio commented Mar 20, 2023

I'll move the milestone to 22.1 because I'm about to start the 22.0 code freeze. Feel free to revert if necessary.

@mokagio mokagio modified the milestones: 22.0, 22.1 Mar 20, 2023
@mokagio
Copy link
Contributor

mokagio commented Apr 3, 2023

I'll move the milestone to 22.2 because I'm about to start the 22.1 code freeze. Feel free to revert if necessary.

@salimbraksa @joashrajin any input on the impact and urgency of this crash? We've been pushing it to the next milestone for a number of releases. If it's low priority at the moment, maybe we should remove the milestone and track it someplace else. I see it's already part of a project, so it won't get forgotten even if we remove the milestone or move it to Someday

@mokagio mokagio modified the milestones: 22.1, 22.2 Apr 3, 2023
@mokagio
Copy link
Contributor

mokagio commented Apr 16, 2023

I'll take the lack of reply to my question two weeks ago as a yes on moving this to Someday instead of pushing it to the next milestone every release cycle.

@mokagio mokagio modified the milestones: 22.2, Someday Apr 16, 2023
@joashrajin
Copy link
Author

@mokagio sorry for missing your ping. Yes, I don’t think this is a high priority issue

@sentry-io
Copy link

sentry-io bot commented Apr 16, 2023

Sentry issue: WORDPRESS-IOS-3P28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants