Handles Default User-Agent Failure #2961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonis
force-pushed
the
fix/defaultuseragent-kotlin
branch
from
0c39287 to
22bd254
Compare
antonis
force-pushed
the
fix/defaultuseragent-kotlin
branch
from
22bd254 to
abf37d1
Compare
antonis
commented
Feb 27, 2024
13 tasks
jarvislin
approved these changes
Feb 28, 2024
fluxc/src/test/java/org/wordpress/android/fluxc/network/UserAgentTest.kt
Outdated
Show resolved
Hide resolved
fluxc/src/test/java/org/wordpress/android/fluxc/network/UserAgentTest.kt
Outdated
Show resolved
Hide resolved
Co-authored-by: Jarvis Lin <[email protected]>
|
Thank you for reviewing and your suggestions @jarvislin 🙇
I wasn't able to reproduce the crash either but tested that the app would perform as expected when the fallback exception case is used similar to how it works in the WordPress app initialiser |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Partially wordpress-mobile/WordPress-Android#20147 (comment)
WordPress-AndroidPR: wordpress-mobile/WordPress-Android#20296Description
This PR converts the
UserAgentclass to Kotlin and handles the exception thrown when the default user agent cannot be retrieved preventing a runtime crash.(internal ref: pcdRpT-5Us-p2)
Note: A similar implementation is employed in the WordPress app initialiser
To Test
To test the app behaviour in the exception case you can use this fallback.patch