Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request only the required fields in fetchPostList request #1379

Merged
merged 2 commits into from
Sep 25, 2019
Merged

Request only the required fields in fetchPostList request #1379

merged 2 commits into from
Sep 25, 2019

Conversation

malinajirka
Copy link
Contributor

@malinajirka malinajirka commented Aug 30, 2019 •
edited
Loading

Fixes #1277

Note: This is just a draft PR since the change on the API hasn't been merged yet D29715-pha.

Modifies the fetchPostList request so we don't waste users' data. We were previously fetching the whole meta object, because further filtering wasn't supported on the API level. However, filtering support was added in D29715-pha.

To test

  1. Use this version of FluxC in WPAndroid
  2. Open the Post list
  3. Use for example Stetho to check details of the request
  4. Make sure the meta.autosave object doesn't contain any other data but "modified".

cc @jkmassel

@malinajirka malinajirka requested review from maxme and shiki August 30, 2019 09:56
@shiki
Copy link
Member

shiki commented Sep 24, 2019

@malinajirka Since D29715-pha was merged, I guess we can open this now?

@malinajirka malinajirka marked this pull request as ready for review September 25, 2019 06:46
@oguzkocer oguzkocer self-assigned this Sep 25, 2019
oguzkocer
oguzkocer approved these changes Sep 25, 2019
View reviewed changes
Copy link
Contributor

@oguzkocer oguzkocer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :shipit:

@oguzkocer oguzkocer merged commit 3de0525 into master-remote-auto-save Sep 25, 2019
@oguzkocer oguzkocer deleted the issue/1277-save-users-data branch September 25, 2019 14:59
@shiki shiki mentioned this pull request Sep 25, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oguzkocer oguzkocer oguzkocer approved these changes

@maxme maxme Awaiting requested review from maxme

@shiki shiki Awaiting requested review from shiki

Assignees

@oguzkocer oguzkocer

Labels
Offline Support [Store] Post Tech Debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@malinajirka @shiki @oguzkocer