Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch only autosave.modifiedDate object instead of the whole meta object #1277

Closed
malinajirka opened this issue May 30, 2019 · 7 comments
Closed

Comments

@malinajirka
Copy link
Contributor

The introduction of the List Management component changed the way we fetch posts from the server. We basically first fetch just list of ids, modifiedDates and statuses -> if the PostModel in our local database has the same status and modified date, we don't fetch its detailed data. This approach saves tons of data and is also more performant.

However, we've started fetching the whole "meta" object here - this change was introduced in this PR as we didn't come up with a better solution.

Ideal fix for this issue is to add support for requesting specific nested fields to the API -> we'd request just "meta.data.autosave.modified" instead of the whole meta object.

cc @shiki @maxme

@shiki
Copy link
Member

shiki commented May 30, 2019

Sounds good to me. @malinajirka, have you measured how big the meta objects can be?

@malinajirka
Copy link
Contributor Author

The difference is significant. This is just an example + if you take into account the autosave.content can be huge, I believe this ticket should have at least a medium priority.
Screenshot 2019-05-30 at 19 04 18

vs
Screenshot 2019-05-30 at 19 05 04

@shiki
Copy link
Member

shiki commented May 30, 2019

Thank you. I agree. That is significant.

@maxme
Copy link
Contributor

maxme commented May 31, 2019

Sounds good to me. I had a look at the API doc and I'm not sure how this is doable.

I tried meta=data.autosave.modified and meta=autosave.modified but it doesn't work.

@malinajirka
Copy link
Contributor Author

Yes, sorry. I should have been more explicit. This is not supported on the API at the moment. I created this ticket so we don't forget about it and propose the change to the API team.

@yaelirub yaelirub added the 5 5 point estimation label Jun 11, 2019
@malinajirka
Copy link
Contributor Author

The api change request is being discussed here - p3hLNG-14E-p2.

@shiki
Copy link
Member

shiki commented Sep 25, 2019

Fixed in #1379

@shiki shiki closed this as completed Sep 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants