Merge release 12.5 into master #9922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 3e09eda
The method `LocalDraftUploadStarter.uploadLocalDrafts` is called when: - The internet comes back online - The Posts activity is shown - When the user performs a pull-to-refresh in any of the Posts tabs
- Removed unnecessary `@Provides` 🤦♂️ - Using a simple `getPostsForSite()` method for now. This should probably be replaced with a FluxC method
It does not need to be a singleton right now. Perhaps later.
Also added helpers.
In this way, we can guarantee that `site` is not `null`.
The `mocked*` can be misleading because the returned instances are not mocks. It is the parameters that are mocked.
Run connected tests nightly on Firebase Test Lab
This uses the new `CONTRIBUTING.md` template reviewed by Editorial. Please see p2JRYi-41r-p2 for more information. The only additional change here is the addition of the _Development Practices_ section which emphasizes the coding style and our other guides in the Wiki. The original content was moved to the Wiki for consistency with our other guides: - [Using Android Resources](https://github.com/wordpress-mobile/WordPress-Android/wiki/Using-Android-Resources) - [Pull Request Guidelines](https://github.com/wordpress-mobile/WordPress-Android/wiki/Pull-Request-Guidelines) - [Subtree'd Library Projects](https://github.com/wordpress-mobile/WordPress-Android/wiki/Subtree'd-Library-Projects)
…-failure Fix Android Test build errors caused by Gutenberg change
…uting-from-template Update CONTRIBUTING.md based on the template
Sign app for release in tools/install-app-bundle.sh
…ia_utils A fix for a crash when uploading media on certain devices
Update Gutenberg to the 1.5.0 release branch
Update Gutenberg to v1.5.1
Merge release/12.4 into develop
…o-12.5 Merge release 12.4 into 12.5
Generated by 🚫 dangerJS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge release 12.5 into master