Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sign app for release in tools/install-app-bundle.sh #9883

Merged
merged 1 commit into from
May 20, 2019

Conversation

jtreanor
Copy link
Contributor

This matches the logic from woocommerce/woocommerce-android#1028 by signing the app when it is installed with ./tools/install-app-bundle.sh.

To test:

  • Build the app bundle: ./tools/build-release-app-bundle.sh update-app-bundle-scripts.
  • Install it: ./tools/install-app-bundle.sh build/wpandroid-12.4-rc-3.aab.
  • Check that the app works (including Google login).

You can skip the first step if you already have an app bundle to test.

Update release notes:

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.

@jtreanor jtreanor added this to the 12.5 milestone May 17, 2019
@jtreanor jtreanor requested a review from loremattei May 17, 2019 13:38

task clean(type: Delete) {
delete rootProject.buildDir
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was causing the scripts to fail and it deletes the build/ directory where the outputs are placed.

Copy link
Contributor

@loremattei loremattei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes looks good to me and the tests were ok.

:shipit:

@loremattei loremattei merged commit 7af080a into develop May 20, 2019
@loremattei loremattei deleted the update-app-bundle-scripts branch May 20, 2019 07:14
@peril-wordpress-mobile
Copy link

Fails
🚫

Could not find Dangerfile at org/common.ts on wordpress-mobile/peril-settings on branch master

Full state of PR run:

{
"branch": null,
"dangerfileBranchForPR": "update-app-bundle-scripts",
"neededDangerfileIsLocalRepo": false,
"repoForDangerfileRun": "wordpress-mobile/peril-settings",
"run": {
  "action": "closed",
  "dslType": 0,
  "event": "pull_request",
  "branch": "master",
  "dangerfilePath": "org/common.ts",
  "repoSlug": "wordpress-mobile/peril-settings",
  "referenceString": "wordpress-mobile/peril-settings@org/common.ts",
  "feedback": 0
},
"settings": {
  "commentableID": 9883,
  "eventID": "Unknown",
  "hasRelatedCommentable": true,
  "installationID": 678301,
  "installationSettings": {
    "env_vars": [],
    "ignored_repos": [
      "wordpress-mobile/peril-settings"
    ],
    "modules": []
  },
  "isRepoEvent": true,
  "isTriggeredByUser": true,
  "repoName": "wordpress-mobile/WordPress-Android",
  "repoSpecificRules": {
    "pull_request, pull_request.labeled, pull_request.unlabeled": "wordpress-mobile/peril-settings@org/android.ts"
  },
  "triggeredByUsername": "loremattei"
}
}

Generated by 🚫 dangerJS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants