Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Treat response.pagination field as nullable #9857

Merged
merged 1 commit into from
May 21, 2019
Merged

Treat response.pagination field as nullable #9857

merged 1 commit into from
May 21, 2019

Conversation

planarvoid
Copy link
Contributor

@planarvoid planarvoid commented May 14, 2019 •
edited
Loading

Fixes #8977
The response.pagination field in the Giphy response is nullable and we have to treat it as such. I'm adding a fallback to response.data.size when the pagination object is null.

Update release notes:

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.

@planarvoid planarvoid added this to the 12.5 milestone May 14, 2019
@planarvoid planarvoid requested a review from malinajirka May 14, 2019 12:48
@planarvoid planarvoid self-assigned this May 14, 2019
@planarvoid planarvoid mentioned this pull request May 14, 2019
Closed
8 tasks
@malinajirka malinajirka self-assigned this May 15, 2019
@loremattei loremattei modified the milestones: 12.5 ❄️, 12.6 May 20, 2019
@loremattei
Copy link
Contributor

Hey! I'm moving this to 12.6 since 12.5 has been cut. If you want this to land 12.5, please feel free to target the release branch and ping me to build a new beta.

malinajirka
malinajirka approved these changes May 21, 2019
View reviewed changes
Copy link
Contributor

@malinajirka malinajirka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

@malinajirka malinajirka merged commit e04fc7c into develop May 21, 2019
@malinajirka malinajirka deleted the fix_crash_in_giphy_picker branch May 21, 2019 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malinajirka malinajirka malinajirka approved these changes

Assignees

@planarvoid planarvoid

@malinajirka malinajirka

Labels
[Type] Crash
Projects
None yet
Milestone
12.6
Development

Successfully merging this pull request may close these issues.

IllegalStateException in GiphyPickerDataSource
3 participants
@planarvoid @loremattei @malinajirka