Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IllegalStateException in GiphyPickerDataSource #8977

Closed
jtreanor opened this issue Jan 16, 2019 · 0 comments · Fixed by #9857
Closed

IllegalStateException in GiphyPickerDataSource #8977

jtreanor opened this issue Jan 16, 2019 · 0 comments · Fixed by #9857
Assignees
Milestone

Comments

@jtreanor
Copy link
Contributor

This was first seen in 11.5-rc-1

Here is the log:

Fatal Exception: java.lang.IllegalStateException: response.pagination must not be null
       at org.wordpress.android.viewmodel.giphy.GiphyPickerDataSource$loadInitial$1.onComplete(GiphyPickerDataSource.kt:80)
       at org.wordpress.android.viewmodel.giphy.GiphyPickerDataSource$loadInitial$1.onComplete(GiphyPickerDataSource.kt:16)
       at com.giphy.sdk.core.threading.ApiTask$1$1.run(ApiTask.java:108)
       at android.os.Handler.handleCallback(Handler.java:898)
       at android.os.Handler.dispatchMessage(Handler.java:107)
       at android.os.Looper.loop(Looper.java:198)
       at android.app.ActivityThread.main(ActivityThread.java:6716)
       at java.lang.reflect.Method.invoke(Method.java)
       at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:493)
       at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:858)

It seems to be crashing with a null response.pagination on this line: https://github.com/wordpress-mobile/WordPress-Android/blob/develop/WordPress/src/main/java/org/wordpress/android/viewmodel/giphy/GiphyPickerDataSource.kt#L80

5c238a19f8b88c296340c240-fabric

@jtreanor jtreanor added this to the 11.6 milestone Jan 16, 2019
@jtreanor jtreanor modified the milestones: 11.6, 11.7 Jan 25, 2019
@loremattei loremattei modified the milestones: 11.7 ❄️, 11.8, 11.8 ❄️, 11.9 Feb 11, 2019
@jtreanor jtreanor modified the milestones: 11.9 ❄️, 12.0 Mar 11, 2019
@jtreanor jtreanor modified the milestones: 12.0 ❄️, 12.1 Mar 25, 2019
@jtreanor jtreanor modified the milestones: 12.1 ❄️, 12.2 Apr 8, 2019
@loremattei loremattei modified the milestones: 12.2 ❄️, 12.4 Apr 23, 2019
@planarvoid planarvoid self-assigned this May 14, 2019
@loremattei loremattei modified the milestones: 12.4 ❄️, 12.5 May 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants