Bring fix images private sites solution to release 12 1 #9524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jtreanor @elibud made this PR in case the fix made by @marecar3 needs to get into |
|
I think it would be great to ship this on Monday if we feel confident about the fix. |
|
Hey @mzorz we can merge this one! Just there is one comment. |
marecar3
reviewed
Apr 6, 2019
| } | ||
|
|
||
| @Override | ||
| public void onSaveInstanceState(Bundle outState) { |
There was a problem hiding this comment.
My latest commit on the PR doesn't have this method. https://github.com/wordpress-mobile/WordPress-Android/pull/9523/files
There was a problem hiding this comment.
thanks for the heads up - addressed in 7cf3d94. Will merge after CircleCI goes green.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brings the fix in #9523 to
release/12.1To test:
Update release notes:
RELEASE-NOTES.txt.