Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes broken Images on private sites in local preview #9523

Conversation

marecar3
Copy link
Contributor

@marecar3 marecar3 commented Apr 5, 2019

Fixes # #8964

Initial problem was that EditPreviewPostFragment wasn't using WPWebViewClient as a client in WebView which exposed an issue #8964. (Missing logic for inserting the token when fetching private site image)

To test:

Steps to reproduce the behavior

Test A:

  1. Select a WordPress.com Simple site and set it to Private.
  2. Start a new post.
  3. Add an image to the post. (Wait for it to upload or select an image from the site's media library.)
  4. Preview the post. Result: The local draft shows an image.
  5. Back to the post, add some content
  6. Preview the post. Result: It should have the latest changes
  7. Rotate device. Result: Content should be there

Update release notes:

  • If there are user-facing changes, I have added an item to RELEASE-NOTES.txt.
    xt`.

@mzorz
Copy link
Contributor

mzorz commented Apr 5, 2019

Should the base branch be release/12.1 @marecar3 ?

@mzorz mzorz added this to the 12.1 ❄️ milestone Apr 6, 2019
Copy link
Contributor

@mzorz mzorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the scenarios, enabled Don't keep activities and rotated, etc and works alright 👍
Code LGTM as well, so :shipit:

@mzorz mzorz merged commit 4bb7499 into develop Apr 6, 2019
@marecar3 marecar3 deleted the fix/8964_Images-on-private-sites-are-broken-in-local-preview_quick_fix branch April 26, 2019 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants