Issue/glide fallback placeholder #7976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
planarvoid
reviewed
Jul 2, 2018
| @@ -79,55 +78,63 @@ class ImageManager @Inject constructor() { | |||
| } | |||
| } | |||
|
|
|||
| private fun addPlaceholder(request: GlideRequest<Drawable>, imageType: ImageType): GlideRequest<Drawable> { | |||
There was a problem hiding this comment.
this might be a good usecase for a private extension function, especially since this is basically a builder pattern
There was a problem hiding this comment.
Great idea, it looks better now!
| import javax.inject.Singleton | ||
|
|
||
| @Singleton | ||
| class ImagePlaceholderManager @Inject constructor() { |
There was a problem hiding this comment.
I love this class 👍 Is it worth testing it? It's probably not necessary
| } | ||
| } | ||
|
|
||
| fun getPlaceholderImage(imgType: ImageType): Int? { |
There was a problem hiding this comment.
Maybe let's rename both to getPlaceholderResource since they are not really returning images?
planarvoid
approved these changes
Jul 2, 2018
|
Thanks for the review @planarvoid ! It's ready for another round;). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#7975
Fixes missing placeholder and error images in the Reader. Behavior is basically copied from
WPNetworkImageView.showDefaultImage()andWPNetworkImageView.showErrorImage().To test:
Placeholder
Error