Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GIF Support - EditPostSettings #7968

Closed
wants to merge 3 commits into from

Conversation

malinajirka
Copy link
Contributor

@malinajirka malinajirka commented Jun 29, 2018

Fixes #7967

Replaces Volley with Glide in the EditPostSettings.
Adds support for adding animated feature images.

To test:

  1. Click on the create post button

  2. Type any title

  3. Click on three dots in the top right corner of the screen

  4. Click on Post Settings

  5. Click on the Set feature image button

  6. Select any GIF image

  7. Notice the animation is working and click on the Publish button

  8. Go to Reader - Followed Sites

  9. Make sure the post has animated GIF image

@malinajirka malinajirka added this to the 10.5 milestone Jun 29, 2018
@malinajirka malinajirka requested a review from oguzkocer June 29, 2018 15:54
@malinajirka
Copy link
Contributor Author

malinajirka commented Jul 2, 2018

@oguzkocer I changed the size of the feature image preview. Previous implementation was using 'thumbnail', which has quite a low quality. Current implementation uses the full image and optimizes it using Photon.

before-now

@malinajirka malinajirka added [Status] Needs Design Review A designer needs to sign off on the implemented design. and removed [Status] Not Ready for Review labels Jul 2, 2018
@malinajirka
Copy link
Contributor Author

I'll create another PR when #7976 is merged and the code is ready for review.

@malinajirka malinajirka closed this Jul 2, 2018
@malinajirka malinajirka deleted the feature/glide-post-settings branch July 3, 2018 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] Needs Design Review A designer needs to sign off on the implemented design.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant