Send Android lint reports to GitHub Code Scanning #21207
Conversation
|
 |
App Name |  Jetpack |
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr21207-cc99dd3 | |
| Commit | cc99dd3 | |
| Direct Download | jetpack-prototype-build-pr21207-cc99dd3.apk |
|
 |
App Name |  WordPress |
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr21207-cc99dd3 | |
| Commit | cc99dd3 | |
| Direct Download | wordpress-prototype-build-pr21207-cc99dd3.apk |
.buildkite/commands/lint.sh
Outdated
| lint_exit_code=$? | ||
| set -e | ||
|
|
||
| upload_sarif_to_github "WordPress/build/reports/lint-results-wordpressVanillaRelease.sarif" |
There was a problem hiding this comment.
We can't send 2 report files, so I decided to stick to WordPress one for no specific reason over Jetpack.
There was a problem hiding this comment.
If I were to chose between WordPress or Jetpack @wzieba , I would personally chose Jetpack instead. I would do so because the WordPress app is a subset of the Jetpack app and doesn't contain every feature. Having said that, I understand that the codebases is almost fully shared between the two and that those Jetpack features not available to WordPress is behind a feature flag or an if/else statement of some kind, located on the main sourceset, which means, it applies to both apps. Still, I think, even conceptually, if I had the choice, I would chose Jetpack. 😊
There was a problem hiding this comment.
Gotcha - thanks! I've updated in cc99dd3
wzieba
changed the title
As WordPress is a subset of Jetpack
|
There was a problem hiding this comment.
👋 @wzieba !
I have reviewed and also tested (#21245) this PR, everything seems to be working as expected, awesome job on introducing this new workflow, in this and every other client project! 🌟
Additionally, I suggested using Jetpack over WordPress, if that's worth it of a quick change, but nothing blocking (context).
Description
This PR introduces integration with GitHub Code Scanning feature for Android lint.
Internal project reference: paaHJt-7ay-p2
To Test:
Check: https://github.com/wordpress-mobile/WordPress-Android/security/code-scanning?page=1&query=is%3Aopen+branch%3Atrunk+pr%3A21207 and verify there are issues reported by Android lint.