-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upload sarif report file to gh registry #111
Conversation
bin/upload_sarif_to_gh
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May I suggest a more explicit upload_sarif_to_github
name for this command?
- if sarif file exists and is readable - if GITHUB_TOKEN exists
Thank you @AliSoftware for your suggestions! I think I applied all of them, TIL Sarif file upload seems to still work fine: https://buildkite.com/automattic/wordpress-android/builds/19758#0191c2f0-4126-4a92-8873-9cd82349888c/245-294 Ready for a second round |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CHANGELOG.md
.
Apart from this, LGTM, so approving to unblock.
Description
This PR introduces a new script that sends a
sarif
file to GH registry using REST API.CHANGELOG.md
if necessary.