Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload sarif report file to gh registry #111

Merged
merged 15 commits into from
Sep 9, 2024
Merged

Conversation

wzieba
Copy link
Member

@wzieba wzieba commented Sep 5, 2024

Description

This PR introduces a new script that sends a sarif file to GH registry using REST API.


  • I have considered if this change warrants release notes and have added them to the appropriate section in the CHANGELOG.md if necessary.

@wzieba wzieba changed the title [WIP] Android lint to gh registry Upload sarif report file to gh registry Sep 5, 2024
@wzieba wzieba marked this pull request as ready for review September 5, 2024 15:04
@wzieba wzieba requested a review from AliSoftware September 5, 2024 15:04
bin/upload_sarif_to_gh Outdated Show resolved Hide resolved
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May I suggest a more explicit upload_sarif_to_github name for this command?

bin/upload_sarif_to_gh Outdated Show resolved Hide resolved
bin/upload_sarif_to_gh Outdated Show resolved Hide resolved
@wzieba
Copy link
Member Author

wzieba commented Sep 5, 2024

Thank you @AliSoftware for your suggestions! I think I applied all of them, TIL mktemp.

Sarif file upload seems to still work fine: https://buildkite.com/automattic/wordpress-android/builds/19758#0191c2f0-4126-4a92-8873-9cd82349888c/245-294

Ready for a second round

@wzieba wzieba requested a review from AliSoftware September 5, 2024 16:16
bin/upload_sarif_to_github Show resolved Hide resolved
bin/upload_sarif_to_github Outdated Show resolved Hide resolved
bin/upload_sarif_to_github Outdated Show resolved Hide resolved
@wzieba wzieba requested a review from AliSoftware September 9, 2024 10:07
Copy link
Contributor

@AliSoftware AliSoftware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Don't forget to add an entry for this new feature in our CHANGELOG.md.

Apart from this, LGTM, so approving to unblock.

@wzieba wzieba merged commit b15c20a into trunk Sep 9, 2024
13 checks passed
@wzieba wzieba deleted the android-lint-to-gh-registry branch September 9, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants