-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Prevent Gutenberg connection logic from crashing Aztec #20053
fix: Prevent Gutenberg connection logic from crashing Aztec #20053
Conversation
|
App Name | ![]() |
|
Flavor | Jalapeno | |
Build Type | Debug | |
Version | pr20053-a931b5d | |
Commit | a931b5d | |
Direct Download | jetpack-prototype-build-pr20053-a931b5d.apk |
|
App Name | ![]() |
|
Flavor | Jalapeno | |
Build Type | Debug | |
Version | pr20053-a931b5d | |
Commit | a931b5d | |
Direct Download | wordpress-prototype-build-pr20053-a931b5d.apk |
Generated by 🚫 dangerJS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested the Classic editor on trunk, and could reproduce the crash when going offline with an opened editor. Tested it again, running this fix, and the crash did not occur. 🎉
Thank you for the quick fix, David! 🚀
A network connectivity subscriber was added to the post activity in: #19692 However, it was not scoped to only run in the Gutenberg editor. Because no guard was in place, the subscriber attempted to invoke a non-existent method on the Aztec editor, resulting in a crash.
ab18f0e
to
a931b5d
Compare
Description
A network connectivity subscriber was added to the post activity in: #19692
However, it was not scoped to only run in the Gutenberg editor. Because
no guard was in place, the subscriber attempted to invoke a non-existent
method on the Aztec editor, resulting in a crash.
Fixes #20052
To Test:
Regression Notes
Regressions could be introduced to the Gutenberg or Aztec editor.
Manual tested both editors for basic usage; e.g., text entry, toggling network
connectivity.
None. Lack of existing Aztec tests boilerplate and unfamiliarity with the
testing infrastructure.
PR Submission Checklist:
RELEASE-NOTES.txt
if necessary.UI Changes Testing Checklist: