feat: Provide Gutenberg editor network connection status #19692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 29, 2023
|
 |
App Name |  WordPress |
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr19692-079d4a6 | |
| Commit | 079d4a6 | |
| Direct Download | wordpress-prototype-build-pr19692-079d4a6.apk |
|
 |
App Name |  Jetpack |
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr19692-079d4a6 | |
| Commit | 079d4a6 | |
| Direct Download | jetpack-prototype-build-pr19692-079d4a6.apk |
derekblank
approved these changes
Dec 1, 2023
There was a problem hiding this comment.
LGTM. I was able to test successfully via WordPress/gutenberg#56609 (review). 🚀
justtwago
approved these changes
Dec 5, 2023
There was a problem hiding this comment.
Smoke tested on Google Pixel 7 Pro and the editor worked as usual. The only difference I found included the Connected: label, dark editor background, and Initial state is missing error as on the screenshot below.
I assume that this is the debug version-specific changes so approving the PR. If you see that this is not exactly what should be visible on the screen, please let me know.
The code LGTM too! 👍
Enable the block editor to request and respond to changes to the network connection status within the host app.
Enable the editor to request the current status for initial render.
dcalhoun
force-pushed
the
feat/gutenberg-network-status
branch
from
622e3dd to
079d4a6
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
dcalhoun
added a commit
that referenced
this pull request
Jan 26, 2024
A network connectivity subscriber was added to the post activity in: #19692 However, it was not scoped to only run in the Gutenberg editor. Because no guard was in place, the subscriber attempted to invoke a non-existent method on the Aztec editor, resulting in a crash.
12 tasks
dcalhoun
added a commit
that referenced
this pull request
Jan 26, 2024
A network connectivity subscriber was added to the post activity in: #19692 However, it was not scoped to only run in the Gutenberg editor. Because no guard was in place, the subscriber attempted to invoke a non-existent method on the Aztec editor, resulting in a crash.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related
Description
Enable the block editor to request and respond to changes to the network
connection status within the host app.
To test: Smoke test the editor, verify it does not crash.
Regression Notes
The bridge changes could cause the editor to fail to load.
Smoke tested the editor.
None. There is no existing test files for the bridge module. Historically,
we focus tests on the JavaScript counterparts in Gutenberg.
PR Submission Checklist:
RELEASE-NOTES.txtif necessary.UI Changes Testing Checklist: