-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an arrow icon for handling the UI of RTL #19962
Merged
jarvislin
merged 3 commits into
trunk
from
issue/19097-worng-navigation-button-when-using-rtl
Jan 19, 2024
Merged
Add an arrow icon for handling the UI of RTL #19962
jarvislin
merged 3 commits into
trunk
from
issue/19097-worng-navigation-button-when-using-rtl
Jan 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
|
antonis
approved these changes
Jan 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for fixing this @jarvislin 🙇
The added resource looks good and the app behaved as expected when testing it on a Pixel 5 (Android 14) 🎉
LTR | RTL |
---|---|
Generated by 🚫 dangerJS |
@antonis Thanks for the review 👍 |
jarvislin
deleted the
issue/19097-worng-navigation-button-when-using-rtl
branch
January 19, 2024 01:45
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18807
We have two arrow icons, → and ←. We only handle RTL for the ← icon, which causes the two arrows are in the same direction when the device is using the RTL language.
This PR contains a new arrow under the
ldrtl
directory for handling RTL.To Test:
Reader
at the bottom tab.Visit site
Arabic
.Regression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
PR Submission Checklist:
RELEASE-NOTES.txt
if necessary.UI Changes Testing Checklist: