Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation buttons point to the same side when viewing a post in the web for RTL languages. #18807

Closed
tiagomar opened this issue Jul 20, 2023 · 2 comments · Fixed by #19962
Closed

Comments

@tiagomar
Copy link
Contributor

Expected behavior

When viewing a post in the web, navigate back button should point to the right and navigate forward should point to the left.

Actual behavior

Both buttons point to the right.

image

Steps to reproduce the behavior

  1. Configure the device language as an RTL language.
  2. Go to Reader
  3. Select a post and view it in the web browser.
Tested on Samsung Galaxy Note 20, Android 12, JPAndroid 22.8-rc-2.
@antonis
Copy link
Contributor

antonis commented Jan 15, 2024

Verified that the issue is still present on the latest version of the app (24.0-rc-1)

@jarvislin
Copy link
Contributor

jarvislin commented Jan 17, 2024

Root cause
We include an → icon ic_arrow_left_white_24dp under the ldrtl directory which has an inverse direction of the normal arrow ←.
But we don't have the ← icon ic_arrow_right_white_24dp under the ldrtl directory. That's why we got two arrows with the same direction.

I think we just need to simply add a new arrow icon under the ldrtl directory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants