Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WP Individual JP Plugin] Enable FF and add release notes #18199

Merged
merged 3 commits into from
Mar 29, 2023
Merged

[WP Individual JP Plugin] Enable FF and add release notes #18199

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e5daca8
point field to remote config, enabled by default
Mar 29, 2023
9976325
add release notes
Mar 29, 2023
0351365
add PR number to release notes
Mar 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion RELEASE-NOTES.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

22.1
-----

* [**] [WordPress-only] Warns user about sites with only individual plugins not supporting core app features and offers the option to switch to the Jetpack app. [https://github.com/wordpress-mobile/WordPress-Android/pull/18199]

22.0
-----
Expand Down
11 changes: 7 additions & 4 deletions ...src/main/java/org/wordpress/android/util/config/WPIndividualPluginOverlayFeatureConfig.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,18 @@
package org.wordpress.android.util.config

import org.wordpress.android.BuildConfig
import org.wordpress.android.annotation.FeatureInDevelopment
import org.wordpress.android.annotation.Feature
import javax.inject.Inject

@FeatureInDevelopment
private const val WP_INDIVIDUAL_PLUGIN_OVERLAY_REMOTE_FIELD = "wp_individual_plugin_overlay"

@Feature(WP_INDIVIDUAL_PLUGIN_OVERLAY_REMOTE_FIELD, true)
class WPIndividualPluginOverlayFeatureConfig @Inject constructor(
appConfig: AppConfig
) : FeatureConfig(
appConfig,
BuildConfig.WP_INDIVIDUAL_PLUGIN_OVERLAY,
appConfig,
BuildConfig.WP_INDIVIDUAL_PLUGIN_OVERLAY,
WP_INDIVIDUAL_PLUGIN_OVERLAY_REMOTE_FIELD
) {
override fun isEnabled(): Boolean {
return super.isEnabled() && !BuildConfig.IS_JETPACK_APP
Expand Down