Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WP Individual JP Plugin] Enable FF and add release notes #18199

Merged
merged 3 commits into from
Mar 29, 2023

Conversation

thomashorta
Copy link
Contributor

Fixes #18198

To test:

  1. Install the app and clear the app storage
  2. Login with an account that has problem sites
  3. Verify the overlay is shown on top of the Login Epilogue (site picker right after login)

Another way to confirm is by going to App Settings > Debug Settings and confirming the wp_individual_plugin_overlay is ON by default.

Regression Notes

  1. Potential unintended areas of impact
    N/A

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    N/A

  3. What automated tests I added (or what prevented me from doing so)
    N/A

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@thomashorta thomashorta added this to the 22.1 milestone Mar 29, 2023
@thomashorta thomashorta requested a review from RenanLukas March 29, 2023 15:31
@thomashorta thomashorta self-assigned this Mar 29, 2023
@wpmobilebot
Copy link
Contributor

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr18199-0351365
Commit0351365
Direct Downloadjetpack-prototype-build-pr18199-0351365.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr18199-0351365
Commit0351365
Direct Downloadwordpress-prototype-build-pr18199-0351365.apk
Note: Google Login is not supported on these builds.

@thomashorta thomashorta changed the title Issue/18198 wp jp plugin overlay enable [WordPress Individual JP Plugin] Enable FF and add release notes Mar 29, 2023
@thomashorta thomashorta changed the title [WordPress Individual JP Plugin] Enable FF and add release notes [WP Individual JP Plugin] Enable FF and add release notes Mar 29, 2023
Copy link
Contributor

@RenanLukas RenanLukas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@thomashorta thomashorta merged commit 741a8b6 into trunk Mar 29, 2023
@thomashorta thomashorta deleted the issue/18198-wp-jp-plugin-overlay-enable branch March 29, 2023 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[WordPress Individual JP Plugin] Enable FF and add release notes
3 participants