Merge release/19.7 Release Notes #16376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ign-buttons [Site Name] Adjusts design picker buttons for treatment variation
Not needed anymore now that the upload of changelogs/*.txt have recently been automated via `upload_to_play_store` See #16235
Now that they won't be needed nor generated anymore
Co-authored-by: Gio Lodi <[email protected]>
…e-notes-xml [Tooling] Remove release_notes.xml file now that changelog upload has been automated via supply
AliSoftware
commented
Apr 21, 2022
| @@ -3339,6 +3339,7 @@ | |||
| <string name="hpp_title">Choose a design</string> | |||
| <string name="hpp_subtitle">Pick your favorite homepage layout. You can edit and customize it later.</string> | |||
| <string name="hpp_choose_button">Choose</string> | |||
| <string name="hpp_choose_and_create_site">Create site</string> | |||
There was a problem hiding this comment.
I decided to manually update the frozen strings file here to add the new string that landed via #16360 post-code-freeze (and thus initially missed the cut).
Even if the new string landed too late for it to be included in the WeeklyKit which was already sent to our Translation Vendor two days ago, that will at least gives that string a chance to be translated by the polyglots community before end of sprint.
|
You can test the changes on this Pull Request by downloading the APKs: |
jkmassel
approved these changes
Apr 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR lands Editorialized Release Notes in time for them to be translated.
PS: While I was working on this, I noticed by chance that a feature PR #16360 landed in the
release/*branch in the meantime. Since I wasn't made aware of it and was not urged to make a new beta for it yet, I'll wait for a more opportune moment — when I have more wiggle room in my todo list — to make a new beta later in the sprint to ship it. But at least that explains the extra content in this diff besides the Release Notes update, even if there was no associateed new beta for it yet.The diff also includes changes from the tooling PR #16281 (which was already reviewed and approved)