Merge final release/19.5 + automation fixes #16235
Conversation
When it also uploads the aab and create a release draft on PlayStore
So that longer descriptions from GlotPress don't end up being rejected by PlayStore when trying to update them with fastlane supply
And not default to WordPress in all cases — especially for the `upload_build_to_play_store` lane now that it uses `skip_upload_metadata: false` for WP and JP production builds
Now that this is automated via fastlane supply (aka `upload_to_play_store` during the `upload_build_to_play_store` lane, we should not be needing this anymore. Keeping it for a couple of sprints still just in case as a fallback, until we validate with a couple of releases that the new way works without any issue, but we should delete that in a release or two once the new way has made its proofs.
|
You can test the changes on this Pull Request by downloading the APKs: |
| metadata_path: metadata_dir, | ||
| skip_upload_metadata: (options[:track] != 'production'), # Only update app title/description/etc. if uploading for Production, skip for alpha/beta tracks | ||
| skip_upload_changelogs: false, |
There was a problem hiding this comment.
This change is part of my plan for this sprint to automate:
- The upload of PlayStore metadata (app title, short and long description, etc) by the CI every time we ship a new production release
- as opposed to only do it manually on demand and when we have a request to update them, which was how it was done so far…
- … which led to the metadata in the PlayStore not always being in sync with the
.txtfiles we had in the repo, not allowing us to use the git history to know about which changes were done in the past and when - while now we'll guarantee to have those in sync for every production release
- The upload of
changelogs/*.txtfile, which was previously done manually by copy/pasting thefastlane/{jetpack_metadata,metadata}/android/release_notes.xmlfile that our tooling generated (but will soon not have to anymore, see below)
| skip_upload_screenshots: true | ||
| skip_upload_screenshots: true, | ||
| json_key: UPLOAD_TO_PLAY_STORE_JSON_KEY |
There was a problem hiding this comment.
This was just to reorder the parameters passed to this upload_to_play_store action call here so they are in line and consistent with all other similar upload_to_play_store calls elsewhere in the Fastfile. Consistency FTW!
| app = get_app_name_option!(options) | ||
| package_name = APP_SPECIFIC_VALUES[app.to_sym][:package_name] | ||
| metadata_dir = File.join('fastlane', APP_SPECIFIC_VALUES[app.to_sym][:metadata_dir], 'android') | ||
|
|
||
| upload_to_play_store( | ||
| package_name: 'org.wordpress.android', | ||
| package_name: package_name, | ||
| metadata_path: metadata_dir, |
There was a problem hiding this comment.
This change makes sure we will be able to use that lane for Jetpack in the future as well as WordPress.
Even if during this sprint this lane was only used with app:wordpress since only the WordPress screenshots were updated (ref: pbArwn-46A-p2), making this lane be compatible with Jetpack will be useful in the future.
| play_store_desc: { desc: 'full_description.txt', max_size: 0 } | ||
| play_store_desc: { desc: 'full_description.txt', max_size: 4000 } |
There was a problem hiding this comment.
This lack of a limit passed in our tooling in the past explains why we had full_description.txt translations that were way larger than the 4000 characters limit present in the repo until now.
Now that I've automated the metadata upload by the CI on each production build (see L579 above), I had to make sure that we discarded any translation for those larger than the limit, to avoid the upload and metadata update in PlayStore to fail (see p1648830761024449-slack-C5ALGJYEP).
This change is what led to the (appropriate) deletion of many full_description.txt files in this PR (basically all the ones for which the translation exceeded that limit and should never have been pulled and stored in the repo in the first place since they never made it to the PlayStore in reality)
| # TODO: Remove this call after a few sprints of validating that that the `skip_upload_metadata: options[:track] != 'production'` recently added to `upload_build_to_play_store` lane works well | ||
| android_create_xml_release_notes(download_path: download_path, build_number: "#{options[:build_number]}", locales: RELEASE_NOTES_LOCALES) | ||
| sh("git add #{download_path} && git commit -m \"Update WordPress metadata translations for #{options[:version]}\" && git push origin HEAD") |
There was a problem hiding this comment.
Hoping to remove that very soon now that I've enabled skip_upload_changelogs: false on line 580 above which makes the CI update the release notes in PlayStore automatically for us, and will avoid the need to copy/paste that generated XML file in the future.
I decided to keep that around for a sprint or two just to still have the generated xml file around as a fallback until I've validated for a release or two that the new automated way works seemlessly, but I definitively plan to remove those calls very soon 🎉
(PR on the release scenario to remove that step from the checklist incoming soon, btw)
| Jetpack: WP-Sicherheit und -Geschwindigkeit | ||
| Jetpack |
There was a problem hiding this comment.
All those changes in title.txt and short_description.txt for Jetpack are related to pxLjZ-6Vi-p2#comment-18922
| <b>CREATE</b> | ||
| - Give your big ideas a home on the web. WordPress for Android is a website builder and a blog maker. Use it to create your website. | ||
| - Pick the right look and feel from a wide selection of WordPress <b>themes</b>, then customize with photos, colors, and fonts so it’s uniquely you. | ||
| - Built-in <b>Quick Start</b> tips guide you through the setup basics to set your new website up for success. (We’re not just a website creator -- we’re your partner and cheering squad!) | ||
| CREATE | ||
| - Give your big ideas a home on the web. WordPress for Android is a website builder and a blog maker. Use it to create your website. | ||
| - Pick the right look and feel from a wide selection of WordPress themes, then customize with photos, colors, and fonts so it’s uniquely you. | ||
| - Built-in Quick Start tips guide you through the setup basics to set your new website up for success. (We’re not just a website creator -- we’re your partner and cheering squad!) |
There was a problem hiding this comment.
Those changes (i.e. removal of the tags) are simply because those tags were never there in the GlotPress originals (and translations) in the first place, so this version without tags is actually how the copies have been looking all those times in GlotPress (and PlayStore) in reality.
| @@ -1,37 +0,0 @@ | |||
| WordPress pour Android vous donne accès à la puissance de la publication sur le Web. Il s’agit d’un créateur de sites Web et plus encore ! | |||
There was a problem hiding this comment.
Deletion of all those fastlane/metadata/android/*/full_description.txt files is because they were all >4000 characters (which is the limit accepted by the PlayStore) and never matched the copy that was used in the PlayStore anyway.
After fixing the missing max_size: 4000 in our tooling (see Fastfile diff above) and re-running the lane, that took care of removing all the files which exceeded the accepted size by PlayStore, hence their deletion here.
The short and full description for the WordPress app will soon get a refresher anyway (ref: pbvYe0-JV-p2) so that's not really a big deal anyway.
Not needed anymore now that the upload of changelogs/*.txt have recently been automated via `upload_to_play_store` See #16235
Not needed anymore now that the upload of changelogs/*.txt have recently been automated via `upload_to_play_store` See #16235
This merges the
release/19.5into trunk after the final release has been built and submitted to PlayStore.It also contains some improvements in the fastfile and automation following the updates of metadata and screenshots in PlayStore which were happening for this release.
Usual final release stuff
changelog/*.txtandrelease_notes.xmlfiles updated with latest translationsvalues*/strings.xmlupdated with latest translationsstrings.xmlexported files… so all thestrings.xmlfiles were still touched in that PR… even if no new strings came up since last time 🙃version.propertiesAdditional stuff
Fastfilegot some changes to allow automating the update of the changelogs and the metadata by CI — see paaHJt-2ga-p2 + more details in PR review below as welltitle.txtandshort_description.txtmetadata files for Jetpack have been updated in this release to address PlayStore change in character limits for the title — see pxLjZ-6Vi-p2short_description.txtandfull_description.txtmetadata files for WordPress have been deleted from the repo.full_description.txtcopies were over the 4000 characters limit), and didn't match what we had for those metadata in the PlayStore anyway (obviously, since what we actually had in the PlayStore had to be <4000 to have been accepted by Google to be saved)short_descriptionandfull_descriptioncopies some time very soon — see pbvYe0-JV-p2