Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove switch to classic from gutenberg #14334

Merged
merged 5 commits into from
Mar 25, 2021

Conversation

cameronvoell
Copy link
Contributor

@cameronvoell cameronvoell commented Mar 24, 2021

Addresses: wordpress-mobile/gutenberg-mobile#3048 (for Android)
See WPiOS PR: wordpress-mobile/WordPress-iOS#16131

Relevant info Borrowed from WPiOS PR:
In discussion with @kyleaparker, we decided that it's best to fast-track the removal of the "switch to classic" option in the block editor. This PR will be scheduled for release in v17.1 alongside a matching change for iOS.

I think this change doesn't warrant inclusion in RELEASE-NOTES.txt, but if anyone thinks differently I'd love to hear.

To test

  1. Select a Simple site
  2. Open a new post in the block editor
  3. Tap the ellipsis button to reveal the options bottom sheet
  4. Verify that there is no longer an option to switch to classic
  5. Repeat Steps 2-4 for Atomic, Jetpack, self-hosted sites

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Mar 24, 2021

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@cameronvoell cameronvoell requested a review from guarani March 24, 2021 02:46
@cameronvoell cameronvoell added the Gutenberg Editing and display of Gutenberg blocks. label Mar 24, 2021
@cameronvoell cameronvoell added this to the 17.1 milestone Mar 24, 2021
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Mar 24, 2021

You can test the changes on this Pull Request by downloading the APK here.

Copy link
Contributor

@guarani guarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on 783faf6 and looks good 🟢

  1. Select a Simple site
  2. Open a new post in the block editor
  3. Tap the ellipsis button to reveal the options bottom sheet
  4. Verify that there is no longer an option to switch to classic
  5. Repeat Steps 2-4 for Atomic, Jetpack, self-hosted sites

(There's a mention of Android in the PR description that should say iOS)

@cameronvoell cameronvoell force-pushed the gutenberg/remove-switch-to-classic branch from 8b3b021 to ae252e0 Compare March 25, 2021 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gutenberg Editing and display of Gutenberg blocks. [Status] Not Ready for Merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants