-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove switch to classic from gutenberg #14334
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
You can test the changes on this Pull Request by downloading the APK here. |
guarani
approved these changes
Mar 24, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on 783faf6 and looks good 🟢
- Select a Simple site
- Open a new post in the block editor
- Tap the ellipsis button to reveal the options bottom sheet
- Verify that there is no longer an option to switch to classic
- Repeat Steps 2-4 for Atomic, Jetpack, self-hosted sites
(There's a mention of Android in the PR description that should say iOS)
cameronvoell
force-pushed
the
gutenberg/remove-switch-to-classic
branch
from
March 25, 2021 17:32
8b3b021
to
ae252e0
Compare
This was referenced Mar 31, 2021
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses: wordpress-mobile/gutenberg-mobile#3048 (for Android)
See WPiOS PR: wordpress-mobile/WordPress-iOS#16131
Relevant info Borrowed from WPiOS PR:
In discussion with @kyleaparker, we decided that it's best to fast-track the removal of the "switch to classic" option in the block editor. This PR will be scheduled for release in v17.1 alongside a matching change for iOS.
I think this change doesn't warrant inclusion in
RELEASE-NOTES.txt
, but if anyone thinks differently I'd love to hear.To test
PR submission checklist:
RELEASE-NOTES.txt
if necessary.