Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gutenberg] File block IV - Error handling, retry, and cancel upload #13449

Closed
wants to merge 2 commits into from

Conversation

etoledom
Copy link
Contributor

@etoledom etoledom commented Nov 23, 2020

This PR updates the gutenberg ref to test WordPress/gutenberg#27146

gutenberg PR: WordPress/gutenberg#27146
gutenberg-mobile PR: wordpress-mobile/gutenberg-mobile#2826

(Screenshots from WPiOS)
Error

Note: This PR is not intended to be merged
Note 2: I have created a temporal gb-mobile branch with File block active, so this PR can be tested using the CI installable build.
Note 3: The design on Android needs to be revised. There are some extra top/bottom paddings that needs to be removed.

To test:

Test cancel action:

  • Add a File block to an empty new post.
  • Add a (big-ish) file to the block.
  • While the file is uploading, tap on the block's background to see the cancel action sheet.
    • If you tap on the file name, it will start editing the file name fileld. This is intended (cc @iamthomasbishop )
  • Tap the Stop upload action.
    • The File block should go back to the empty state.

Test error and retry:

  • Add a File block to an empty new post.
  • While it's uploading, turn un Airplane mode.
    • See the block switch to its error state.
  • While in the error state, tap on the File block background to see the Retry action sheet.
  • After reconnecting the device, press the Retry action.
    • Check that the file starts uploading again until it successfully finishes uploading.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Nov 23, 2020

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link

You can test the changes on this Pull Request by downloading the APK here.

@etoledom
Copy link
Contributor Author

Screenshot_20201125-122247

Fixed design.

@jd-alexander
Copy link
Contributor

@etoledom I know this PR won't be merged but I am just confirming that I tested this branch and I was able to get the updated design in the File Block's error state.

@etoledom
Copy link
Contributor Author

Closing since it's being replaced by #13482

@etoledom etoledom closed this Nov 27, 2020
@etoledom etoledom deleted the gutenberg/file-block-IV-cancel-retry-error branch November 27, 2020 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants