-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RNMobile] File block IV - Error handling, retry, and cancel upload #27146
Conversation
Size Change: 0 B Total Size: 1.2 MB ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for these changes @etoledom I followed the testing instructions and I was able to accomplish the retry/cancel operations on the Android PR that has the File Block enabled for the CI build. On Android, I changed the container style to
.errorContainer {
flex-direction: row;
align-items: flex-start;
}
It aligned the items but there's a lot of space. I wasn't able to test this on iOS as yet.
Below was the Android outcome of adding this style.
d4dbaa7
to
c945f92
Compare
c945f92
to
68bdbd0
Compare
Also added unit test for Error state 🎉 |
All PRs updated and ready for another look 👀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Things are looking good here @etoledom LGTM 🚢 Verified the behavior via the Android testing PR.
e3509a4
to
b84da00
Compare
gutenberg-mobile
PR: wordpress-mobile/gutenberg-mobile#2826WPiOS
(testing) PR: wordpress-mobile/WordPress-iOS#15363WPAndroid
(testing) PR: wordpress-mobile/WordPress-Android#13449Description
This PR implements Error handling for the File Block.
We keep reusing elements from the other media blocks. In this case, the retry action sheet only has the
Retry
option.I have chosen to add the Error label down the file name because of two reasons:
( cc @iamthomasbishop )
How has this been tested?
To test:
Test cancel action:
Stop upload
action.Test error and retry:
Screenshots
Types of changes
Checklist: