Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build in develop #12302

Merged
merged 1 commit into from
Jun 26, 2020
Merged

Fix build in develop #12302

merged 1 commit into from
Jun 26, 2020

Conversation

malinajirka
Copy link
Contributor

Fixes issue in develop which was introduced when READER ImageType was renamed in #12206, but it was also used in da32475 which got merged first.

To test:

  • Successful CI build should be enough

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link

You can test the changes on this Pull Request by downloading the APK here.

Copy link
Member

@khaykov khaykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you for the quick fix 🙇

@khaykov khaykov merged commit 94e10ab into develop Jun 26, 2020
@khaykov khaykov deleted the fix-develop-build branch June 26, 2020 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants