Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RI: Post Card UI - Use default material theme colors #12206

Merged
merged 6 commits into from
Jun 26, 2020

Conversation

ashiagr
Copy link
Contributor

@ashiagr ashiagr commented Jun 16, 2020

This PR addresses feedback to

  • Replace reader specific colors with our default ones (using Emphasis to get variations in the shades)
  • Make the body/excerpt text color the same as the post title color

To test

  • Launch app and go to Reader tab
  • Notice that colors for texts, borders, backgrounds on the post cards look similar to the ones used earlier or are acceptable
    Reference: Figma -> Apps Reader Improvement -> Postcard UI -> postcard anatomy (android)

Note

Trying to figure out how to replace reader_post_list_background with a default one. This is under discussion, will update once we have any decision on it.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@ashiagr ashiagr added this to the 15.2 milestone Jun 16, 2020
@ashiagr ashiagr requested review from khaykov and mbshakti June 16, 2020 06:33
@ashiagr ashiagr self-assigned this Jun 16, 2020
@peril-wordpress-mobile
Copy link

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link

You can test the changes on this Pull Request by downloading the APK here.

@ashiagr ashiagr modified the milestones: 15.2, 15.3 Jun 26, 2020
@khaykov khaykov self-assigned this Jun 26, 2020
Copy link
Member

@khaykov khaykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you so much for the changes 🙇

@khaykov khaykov merged commit 2a8569a into develop Jun 26, 2020
@khaykov khaykov deleted the issue/ri-post-card-ui-material-theming branch June 26, 2020 16:54
@malinajirka malinajirka mentioned this pull request Jun 26, 2020
3 tasks
@mbshakti
Copy link

Looking good!!! Thanks a lot for making the changes @ashiagr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants