Re-enable editor UI tests #12111
Merged
Re-enable editor UI tests #12111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 8e4a56c.
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
|
You can test the changes on this Pull Request by downloading the APK here. |
It is not recommended to mutate a view's state directly, so this approach uses an interaction to ensure the true or false state instead.
Generated by 🚫 dangerJS |
oguzkocer
approved these changes
Jun 15, 2020
There was a problem hiding this comment.
I ran the connected tests on CI multiple times and it passed each time. The block editor test is ignored and I think the addition of setting the editor to classic will resolve the flakiness for the regular editor tests. I don't think we'll have any issues, but let's merge it and keep an eye on it for a bit.
Thanks @mkevins!
|
Thanks for reviewing and testing Oguz! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11897
Description
This PR adds a
ViewActionutility method to set explicitly the editor preference, and sets the specific editor for the Classic and Gutenberg tests.Note: this PR does not yet address the startup time issue with the Gutenberg editor,
so I'm leaving this as draft for now. If a solution to that is not soon available, these changes should allow disabling of only Gutenberg tests, so the Aztec tests can still run.It seems these issues may be resolved? I'll mark this for review, and revisit if there are still problems with the tests timing out.Update:
I encountered some timeout issues with the Gutenberg editor test enabled. Additionally, there were problems with the
signUpWithMagicLinktest (mismatches on API endpoints reported from WireMock). I'm not sure why, but this goes away after disabling the Gutenberg editor test, so I suspect it is related to the editor flag. I've disabled the Gutenberg editor test and everything passes now. It may be worth fixing the Gutenberg editor test in a separate PR so that we don't block re-enabling the Aztec editor tests (since it seems that requires a bit more investigation).To test:
Editor UI tests should pass locally and on CI.
PR submission checklist:
RELEASE-NOTES.txtif necessary.