-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Temporarily disable Editor UI tests #11530
Conversation
You can test the changes on this Pull Request by downloading the APK here. |
WordPress/src/androidTest/java/org/wordpress/android/e2e/EditorTests.java
Outdated
Show resolved
Hide resolved
@jkmassel @rachelmcr I am fairly sure that this PR will fix the CI issue we are having, but unfortunately it's hard to make sure that's the case because when I run the tests locally the missing mock errors show up even though these never do in the CI. I think we'll need to carve out some time to work on these UI tests and fix them once and for all. For now, I think this is safe enough of a PR to just merge. 🤷♂ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This look good to me. All tests under .org.wordpress.android.e2e are now disabled.
when I run the tests locally the missing mock errors show up even though these never do in the CI.
There are some mocks errors that I see when I run wPScreenshotTest
, but we exclude that test from the connected test run on CI since it's only used to generate screenshots for the app store — so that won't affect our CI test runs. (It would be nice to clean that up at some point, though.) All other connected tests pass for me locally.
We are temporarily disabling the Editor UI tests to give us some time to address the aztec/gutenberg issue mentioned here.
To test:
PR submission checklist:
RELEASE-NOTES.txt
if necessary.