Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily disable Editor UI tests #11530

Merged
merged 2 commits into from
Mar 26, 2020

Conversation

oguzkocer
Copy link
Contributor

@oguzkocer oguzkocer commented Mar 25, 2020

We are temporarily disabling the Editor UI tests to give us some time to address the aztec/gutenberg issue mentioned here.

To test:

  • CI should pass.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Mar 25, 2020

You can test the changes on this Pull Request by downloading the APK here.

@oguzkocer oguzkocer requested review from jkmassel and rachelmcr March 25, 2020 18:22
@oguzkocer
Copy link
Contributor Author

@jkmassel @rachelmcr I am fairly sure that this PR will fix the CI issue we are having, but unfortunately it's hard to make sure that's the case because when I run the tests locally the missing mock errors show up even though these never do in the CI.

I think we'll need to carve out some time to work on these UI tests and fix them once and for all. For now, I think this is safe enough of a PR to just merge. 🤷‍♂

Copy link
Member

@rachelmcr rachelmcr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This look good to me. All tests under .org.wordpress.android.e2e are now disabled.

when I run the tests locally the missing mock errors show up even though these never do in the CI.

There are some mocks errors that I see when I run wPScreenshotTest, but we exclude that test from the connected test run on CI since it's only used to generate screenshots for the app store — so that won't affect our CI test runs. (It would be nice to clean that up at some point, though.) All other connected tests pass for me locally.

@jkmassel jkmassel merged commit 39fa915 into develop Mar 26, 2020
@jkmassel jkmassel deleted the issue/temporarily-disable-editor-ui-tests branch March 26, 2020 19:17
hypest added a commit that referenced this pull request Apr 30, 2020
mkevins added a commit that referenced this pull request Jun 5, 2020
…rily-disable-editor-ui-tests"

This reverts commit 39fa915, reversing
changes made to e42b082.
mkevins added a commit that referenced this pull request Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants