-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates .configure to latest hash #11624
Conversation
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
@loremattei Unfortunately this is still failing. I am sure you already know what we need to do, so I am just going to stop wasting time on it. |
Hey @oguzkocer!
Usually the developers update it when the feature they are working on requires an update. Since the repository is shared by a lot of apps, it's not unusual for an app to stay on an old commit until (probably the newer ones are related to other apps).
Did you update the file manually? It looks like there are some inconsistencies. You can use the |
I did 🤦♂ I'll try that today. |
You can test the changes on this Pull Request by downloading the APK here. |
@loremattei When I run the
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me.
I'll follow up with a fix for the error in configure_update
. I verified that it just fails to re-apply the changes, so the error doesn't impact this PR.
This PR updates the pinned hash to the latest commit. It looks like we haven't updated the pinned hash for a very long time. @loremattei Is that something intentional, or did we just not need to do it yet?
To test:
PR submission checklist:
RELEASE-NOTES.txt
if necessary.