Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates .configure to latest hash #11624

Merged
merged 2 commits into from
Apr 9, 2020
Merged

Conversation

oguzkocer
Copy link
Contributor

@oguzkocer oguzkocer commented Apr 8, 2020

This PR updates the pinned hash to the latest commit. It looks like we haven't updated the pinned hash for a very long time. @loremattei Is that something intentional, or did we just not need to do it yet?

To test:

  • Installable build CI task should pass

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@oguzkocer oguzkocer added this to the 14.7 milestone Apr 8, 2020
@oguzkocer oguzkocer requested a review from loremattei April 8, 2020 18:49
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Apr 8, 2020

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@oguzkocer
Copy link
Contributor Author

@loremattei Unfortunately this is still failing. I am sure you already know what we need to do, so I am just going to stop wasting time on it.

@loremattei
Copy link
Contributor

loremattei commented Apr 9, 2020

Hey @oguzkocer!

Is that something intentional, or did we just not need to do it yet?

Usually the developers update it when the feature they are working on requires an update. Since the repository is shared by a lot of apps, it's not unusual for an app to stay on an old commit until (probably the newer ones are related to other apps).

Unfortunately this is still failing.

Did you update the file manually? It looks like there are some inconsistencies. You can use the configure_update fastlane command to properly update the hash.

@oguzkocer
Copy link
Contributor Author

Did you update the file manually? It looks like there are some inconsistencies. You can use the configure_update fastlane command to properly update the hash.

I did 🤦‍♂ I'll try that today.

@peril-wordpress-mobile
Copy link

You can test the changes on this Pull Request by downloading the APK here.

@oguzkocer
Copy link
Contributor Author

@loremattei When I run the configure_update lane, I got some erros, but it looks like it still worked. I need to spend some time learning about our Fastlane setup :(

NoMethodError: [!] undefined method `trigger_action_by_name' for nil:NilClass

Copy link
Contributor

@loremattei loremattei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.
I'll follow up with a fix for the error in configure_update. I verified that it just fails to re-apply the changes, so the error doesn't impact this PR.

@loremattei loremattei merged commit 3ad380e into develop Apr 9, 2020
@loremattei loremattei deleted the issue/update-secrets-hash branch April 9, 2020 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants